kewisch / action-web-ext Goto Github PK

Hi, thanks for the great action!

I'm using this for submit my extension, but firefox addon also need to submit source files when the dist files is minified.

are there any ways to figure out this?

In the README it mentions:

Changing apiUrlPrefix will allow you to submit to addons.thunderbird.net or using the staging/dev instance.

I found the URLs for those instances in the Github addons-server repo and related docs, but have had a hard time trying to find out how to use those staging/dev instances for testing add-on signing. I was able to create an AMO account on the staging instance, but I don't seem to be able to generate API keys there since there's a confirmation email process but the staging environment doesn't send out emails (from what I can tell). I get the following message from https://addons.allizom.org/en-US/developers/addon/api/key/

A confirmation link will be sent to your email address. After confirmation you will find your API keys on this page.

Maybe this question is better posed somewhere else? I've found it difficult to find information about this generally available.

https://github.com/kewisch/action-web-ext/actions?workflow=Build

Just a heads-up that your build pipeline seems to be red/is failing hmm?

…because of linting errors apparently hehe… https://github.com/kewisch/action-web-ext/actions/runs/5899498985/job/16002105872

Hi Philipp,

we talked about this in London last year, but I didn't get to actually look into this until now.
From the readme, I can see how to build and upload an artifact, but what else is needed in order to self-host a beta version on github?

From what I gather, an update link is needed: https://extensionworkshop.com/documentation/manage/updating-your-extension/

But how do you maintain and serve this file via github? Via github pages?
It would be nice if the github action could automatically update the json and push it to a URL that stays the same.

Cheers

would be cool if linting wouldn't require an auth token so it can run in PRs from people not part of the repo

Hi,
I see the README says that

A token is not required for this action, though if GITHUB_TOKEN is in the environment, it will be used to create a check run.

but a recent run on this action on the Shiori web-ext failed with:

call-lint / Lint Error: Parameter token or opts.auth is required

Between the fact the token is not supposed to be needed and that the GITHUB_TOKEN is added to the env in the setup job, i'm wondering if there isn't a bug somewhere.
Thanks!

Can you please guide me here with this issue, I have been trying to solve this but it keeps giving me a timeout error.

Error: Error: Signing took too long to complete; last status: {"guide":"<my-guid>","active":false,"automated_signing":true,"url":"https://addons.mozilla.org/api/v5/addons/guid/versions/1.0.3/uploads/209ae4ff65894279abac119e22c100d0/","files":[{"download_url":"https://addons.mozilla.org/api/v5/file/3848030/xxx-1.0.3-an+fx.xpi","hash":"sha256:010377edd327eda45cbe4797c59e84bd2ec0e9c6761c0368c719fc3e06a75555","signed":false}],"passed_review":null,"pk":"209ae4ff65894279abac119e22c100d0","processed":true,"reviewed":null,"valid":true,"valid...

Last time it ran for almost 6 hours and then gave the timeout error, the fact that I explored this error and find that the delay is caused by AMO and they updated the message explaining what the cause was, here is the link. So I think the pipeline should not be giving error in this scenario. As the pipeline give an error I'm unable to drop the artefact for the download.

Kindly guide me here.
Thanks

Hi @kewisch 👋, using the current rev, I'm hitting an error running the action with the action installed as a submodule local to the repo I'm using it from:

Error: Cannot find module '@node-rs/crc32-linux-x64-gnu'

This looks to be due to the arch specific deps not being part of the committed node_modules. A temporary workaround is possible by adding a step which runs npm install like so:

      - name: workaround missing dep in action-web-ext
        working-directory: .github/actions/action-web-ext
        run: npm install

For me the signing times out after 2 minutes. What's odd about this is that the timeout in sign-addon was actually changed from 2 minutes to 15 minutes a while back and it's still set to 15 minutes as far as I can tell. In trying to find out if I could change it I was going to try providing an explicit timeout but I noticed that option is not exposed in this action. I was wondering how you'd feel about adding that as an option?

I noticed this repository has included the node_modules directory. This causes the git repository to be quite large in size. Are there any reasons for keeping it? I noticed the .gitignore file even explicitly allows it.

I'm getting this warning when using the action:

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

You have not released a new version since 2019, so maybe it's time for a new release?

I tried to use your github action like explained in the documentation (here) but got this error:

Run kewisch/action-web-ext@v1
  with:
    cmd: sign
    source: web-ext-artifacts/ecoindex-1.2.zip
    channel: unlisted
    apiKey: ***
    apiSecret: ***
    timeout: 900000
    artifacts: web-ext-artifacts
    verbose: false
    progressBar: false
    ignoreFiles: []
    apiUrlPrefix: https://addons.mozilla.org/api/v4
  env:
    GITHUB_TOKEN: ***
Error: Error: Must specify an add-on id in the manifest at browser_specific_settings.gecko.id
Error: Must specify an add-on id in the manifest at browser_specific_settings.gecko.id
    at WebExtAction.cmd_sign (file:///home/runner/work/_actions/kewisch/action-web-ext/v1/src/action.js:142:15)
    at async main (file:///home/runner/work/_actions/kewisch/action-web-ext/v1/src/index.js:40:16)

Not sure where I was wrong... Do you have an idea ?