kevintuhumury / milkman Goto Github PK

The URL generated by the new version of the milkman gem always results in this response

Uh oh... something went wrong. Don't worry though; it's not your fault. The application you're using to interact with Remember The Milk made an error. It might be worthwhile contacting the author of the application and telling them you encountered this page.

Looking into a fix, will submit a PR

This is probably my issue, as I'm new to Ruby and have never used tools like Thor...

I couldn't successfully run "milkman authorize KEY SECRET" in a controller method.
(I get "undefined method authorize").
Should I be doing this in a config script somewhere? And/or through Thor?

I'd love it if the README was a bit more explicit about that.

Thank you!

Started exploring milkman, got the following while trying 'milkman authorize'

milkman/lib/milkman/authorizer.rb:18:in `authorize': undefined method `[]' for nil:NilClass (NoMethodError)

I think I've traced it to the fact that HTTParty isn't parsing RTM's response as json, but rather plain text. From what I can tell, RTM's response is mime-type text/javascript, so HTTParty chooses "plain" parsing.

This seems to address the problem:

diff --git a/lib/milkman/request.rb b/lib/milkman/request.rb
index 3b750d2..ca4046d 100644
--- a/lib/milkman/request.rb
+++ b/lib/milkman/request.rb
@@ -24,7 +24,7 @@ module Milkman
     private

     def request
-      @response ||= self.class.get @url
+      @response ||= self.class.get( @url, :format => :json )
     end

Looking for confirmation my understanding is correct, before submitting a pull. Not sure why this is (I assume) working for others..

When I run the authorize command and enter the web address provided it takes me to the web page saying "API Application wants to link to your RTM account" with a button that says "OK, I'll Allow it".

Once I click that it gives me an error saying:

"Uh oh... something went wrong. Don't worry though; it's not your fault. The application you're using to interact with Remember The Milk made an error. It might be worthwhile contacting the author of the application and telling them you encountered this page.

Alternatively, you might like to wait a little while and then try again."

Any help on this would be great.