kevinschaul / d3-star-plot Goto Github PK

All css classes are currently prefixed with star-, which should be customizable.

The includeLabels option is redundant. It can be determined from the value of the labels option.

Figure out a better way to place this information (or remove it from the code completely).

Code is not DRY. Variables that depend on each other should be set using functions.

Current code is bad:

  chart.width = function(_) {
    if (!arguments.length) return width;
    width = _;
    radius = width / 2;
    origin = [radius, radius];
    scale.range([0, radius])
    return chart;
  };

Currently, the star plot allows specifying labels as an array of string values. However, it would be great if the labels could also be provided via a callback function, similar to the way the title is created. Then, one could efficiently add data-based labels, e.g. in order to display the axis value or unit in the label, like so:

// d: datum, i: property index
.labels(function(d, i) {
     return labels[i] + ": " + d[properties[i]].toFixed(1);
 })