Comments (7)
kevinburke
commented on June 25, 2024
Sure... why a function instead of a constant, is the idea that someone else could change a constant?
from go-bindata.
kevinburke
commented on June 25, 2024
I suspect this use case might come up again so it might be good to either have a BuildInfo() struct or function that we can add e.g. compile time etc. to, as well as debug/non-debug.
from go-bindata.
josharian
commented on June 25, 2024
A constant seems fine. I was just not thinking clearly.
from go-bindata.
josharian
commented on June 25, 2024
Thanks for the fix! I was going to send a PR but delighted you beat me to it.
One thought: should it be called AssetDebug or the like? Debug might conflict with existing identifiers in peoples packages.
from go-bindata.
kevinburke
commented on June 25, 2024
It would be guarded by the package import path right? I don’t think it’s
possible to create arbitrary Upper case variable names right now by getting
creative with file names... maybe I’m not understanding
On Mon, May 18, 2020 at 09:12 Josh Bleecher Snyder ***@***.***> wrote:
Thanks for the fix! I was going to send a PR but delighted you beat me to
it.
One thought: should it be called AssetDebug or the like? Debug might
conflict with existing identifiers in peoples packages.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZEI6FTFUXHLX7FEUR5N3RSFM5HANCNFSM4NDOJZGA>
.
--
Kevin Burke
phone: 925-271-7005 | kevin.burke.dev
from go-bindata.
kevinburke
commented on June 25, 2024
Ohhh.. you don’t use this as a standalone package you embed it into a
package that has other files along with it.
Let me think about it.
On Mon, May 18, 2020 at 09:56 Kevin Burke ***@***.***> wrote:
It would be guarded by the package import path right? I don’t think it’s
possible to create arbitrary Upper case variable names right now by getting
creative with file names... maybe I’m not understanding
On Mon, May 18, 2020 at 09:12 Josh Bleecher Snyder <
***@***.***> wrote:
> Thanks for the fix! I was going to send a PR but delighted you beat me to
> it.
>
> One thought: should it be called AssetDebug or the like? Debug might
> conflict with existing identifiers in peoples packages.
>
> —
> You are receiving this because you modified the open/close state.
>
>
> Reply to this email directly, view it on GitHub
> <#31 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABZEI6FTFUXHLX7FEUR5N3RSFM5HANCNFSM4NDOJZGA>
> .
>
--
Kevin Burke
phone: 925-271-7005 | kevin.burke.dev
--
Kevin Burke
phone: 925-271-7005 | kevin.burke.dev
from go-bindata.
josharian
commented on June 25, 2024
I guess it depends on whether people generate code into a separate package or directly into their own. Since the default package path is main, not asset, I assume that that is common. Maybe I’m wrong though.
from go-bindata.
Related Issues (20)
- Go module support HOT 2
- Windows file under "Releases" has no extension and no explanation about how to use it.
- [Feature Request] Add go.mod & go.sum
- staticcheck reports warning HOT 1
- include version as a comments in the generated file HOT 1
- Where is the latest release binary? HOT 5
- Version number needs updating HOT 1
- ignore flag works differently with prefix flag set or not
- [please vote]: Do you put other Go source code in the pkg generated by go-bindata?
- Generated code is not gofmt simplified
- Error when using gosec. HOT 2
- How do I create bindata for linux/s390x? HOT 1
- Is it possible to disable the modified time portion, so that I will see the changes in generated files only when there is genuine changes in the asset files?
- "go test -bench B ." writes files into testdata HOT 1
- Update install from source instructions
- Q: How to unpack a bindata.go file? HOT 1
- Error with linter due to obsolete use of ioutil.WriteFile
- 3.25.0 release did not get completed HOT 4
- Missing go-bindata-linux-amd64 in v4.0.2 release
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-bindata.