minimapbuttonframe-redux's People
minimapbuttonframe-redux's Issues
10.1 Compatiblity
Copied from a comment on a separate issue
Here's what I'm getting
1x .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1: bad argument #1 to 'GetAddOnMetadata' (Invalid AddOn name MinimapButtonFrame. - Usage: local value = C_AddOns.GetAddOnMetadata(name, variable))
[string "=[C]"]: in function `GetAddOnMetadata'
[string "@MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1: in main chunk
Locals:
(*temporary) = "MinimapButtonFrame"
(*temporary) = "Version"
(*temporary) = "Invalid AddOn name MinimapButtonFrame. - Usage: local value = C_AddOns.GetAddOnMetadata(name, variable)"
1x ...ceMinimapButtonFrameRedux_SkinPack/Skins.lua:5: attempt to call global 'MBFAddSkin' (a nil value)
[string "@MinimapButtonFrameRedux_SkinPack/Skins.lua"]:5: in main chunk
Locals:
(*temporary) = nil
(*temporary) = "Hello Kitty"
(*temporary) = "Interface\AddOns\MinimapButtonFrameRedux_SkinPack\Textures\HKittyActive.tga"
(*temporary) = "Interface\AddOns\MinimapButtonFrameRedux_SkinPack\Textures\HKittyActiveBackdrop.tga"
(*temporary) = 35
(*temporary) = "attempt to call global 'MBFAddSkin' (a nil value)"
Originally posted by @Tetsemi in #15 (comment)
Issue adding minimap button
Hello!
I'm the developer of the addon RareScanner, and another user made me the question: "How can I add your minimap button to
Minimap Button Frame Redux", so I tried to follow your tutorial in the description of CurseForge, and I couldn't achieve it, so I checked your code and this is what I found:
-
There is an error parsing the input if you don't use english, for example:
In english:
/MBF ADD LibDBIcon10_RareScannerMinimapIcon
In spanish:
/MBF añadir LibDBIcon10_RareScannerMinimapIcon
It doesn't seem to like the letter "ñ", so in your functionChatCommand
this doesn't work as intended:
#855. local startPos, endPos, firstWord, restOfString = strfind(input, "(%w+)[%s%p]*(.*)");
#856. firstWord = strlower(firstWord)
firstWord takes the value "a", instead of "añadir", so the command doesn't do anything at all.
restOfString takes the value "ñadir LibDBIcon10_RareScannerMinimapIcon
I imagine that you will have the exact same problem with russian, chinesse and other localizations where they have their own letters as spanish (suggestion: don't traslate the commands). -
Once I figured that out, I tried to modify the code and check if I could add my button, however the method
isValidAdd
doesn't seem to like my button. I saw that you match the frames name with a table of values, and like my addon isn't in that list it doesn't return it as a valid candidate. Am I missing something?
Cheers.
v2.0.1 throwing up a LUA error
I haven't quite figured out what's causing this, but this error is being thrown in my LUA error trapper.
Message: bad argument #2 to '?' (Usage: self:SetParent([parent]))
Time: Mon Oct 31 10:00:19 2022
Count: 1
Stack: bad argument #2 to '?' (Usage: self:SetParent([parent]))
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `SetParent'
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1538: in function `restoreButtonSettings'
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1611: in function `removeInvisible'
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1689: in function <.../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1673>
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1749: in function `updatePositions'
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1844: in function `?'
[string "@Interface/AddOns/AnnounceRare/Libraries/Ace3/AceTimer-3.0/AceTimer-3.0.lua"]:55: in function <...nceRare/Libraries/Ace3/AceTimer-3.0/AceTimer-3.0.lua:50>
Locals:
LUA Error - MinimapZoomIn issue
Here's a LUA error being thrown in the latest version of MBF-Redux (2.0.3). The latest Ace3 for 10.0.0 is installed.
7x .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1935: attempt to index global 'MinimapZoomIn' (a nil value)
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1935: in function `MBFC_KeepBlizzHidden'
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1838: in function `?'
[string "@Interface/AddOns/Ace3/AceTimer-3.0-17/AceTimer-3.0.lua"]:55: in function <Interface/AddOns/Ace3/AceTimer-3.0/AceTimer-3.0.lua:50>
Locals:
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index global 'MinimapZoomIn' (a nil value)"
Since the API has changed, I believe there are changes to MinimapZoomIn, MinimapZoomOut, MiniMapMailFrame, MiniMapBattlefieldFrame, etc. (most buttons have been moved to the Minimap namespace, e.g. Minimap.ZoomIn, Minimap.ZoomOut, etc.)
3.2.2 Does not correctly restore show/hide state on login/reload
The show/hide state of MinimapButtonFrame
appears to be saved across sessions in bachMBF.db.profile.mbfHidden
During login, in the function bachMBF:Init()
, it does initially check bachMBF.db.profile.mbfHidden
and hides MinimapButtonFrame
accordingly (MinimapButtonFrameRedux.lua lines 848-849)
However it then calls function MBFC_RollUp()
with a parameter of 1 or 2 based on saved value bachMBF.db.profile.rollUp
(lines 852-855)
MBFC_RollUp()
overrides bachMBF.db.profile.mbfHidden
and changes the show/hide state of MinimapButtonFrame
(lines 2022-2023 & 2030-2031), effectively based on the value of bachMBF.db.profile.rollUp
The end result is that the saved value of bachMBF.db.profile.mbfHidden
always gets overridden and ignored, and the show/hide state of MinimapButtonFrame
does not get correctly restored on login/reload.
RareScanner does not seem to gather
is Ace3 required to run MBF?
Currently Ace3 isn't updated for DF—the current version is 9.2.7. This doesn't seem to be causing any issues (yet, at least I don't think so) but I'm wondering if it's fully required to run MBF properly, or if there's an alternative in case it doesn't get updated.
A lot of my mods are still pretty borked from the 10.0 changes so I've been going through and trying to get rid of anything I don't absolutely need. Thank you
Error 2/5/23
Message: .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1826: attempt to index global 'MiniMapMailFrame' (a nil value)
Time: Sun Feb 5 19:10:09 2023
Count: 1
Stack: .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1826: attempt to index global 'MiniMapMailFrame' (a nil value)
[string "=[C]"]: ?
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1826: in function updatePositions' [string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1862: in function
?'
[string "@Interface/AddOns/Ace3/AceTimer-3.0/AceTimer-3.0.lua"]:55: in function <Interface/AddOns/Ace3/AceTimer-3.0/AceTimer-3.0.lua:50>
Locals:
Not sure if it is Minimap button or Ace 3 problem. I just downloaded the latest Minimap zip file before getting this.
Issues with icons
- The new tracking icon is not being collected by MBF
The "hide tracking" option also does not seem to work.
- Zoom buttons are not displayed on minimap no matter if "Hide Zoom Buttons" option is enabled or not
- The calendar icon has a ring around it, and since the design of it has changed to square, it can probably be excluded from the decoration or somehow rescaled:
Thank you for all your work!
Minimap Border forced to show
The border for minimaps appears to be forced to show by MMBF. I use Sexymap to change my minimap to a square layout, while hiding the default border. When MMBF is on, it forces the border to always show despite this.
Reproduction:
Enable Sexymap, go to options - borders, check "Hide default border". Border is hidden as expected.
Enable MMBF - border now always shows
Disable MMBF - border is back to being hidden.
buttons wont group since ace 3 update
keep getting errors
2x .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1826: attempt to index global 'MiniMapMailFrame' (a nil value)
[string "@MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1826: in function updatePositions' [string "@MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1862: in function
?'
[string "@DataStore/libs/AceTimer-3.0-17/AceTimer-3.0.lua"]:55: in function <DataStore/libs/AceTimer-3.0/AceTimer-3.0.lua:50>
Locals:
processMail = false
childExceptions = 2
avgButtonSize = 38
spacer = 19
x = 328
y = -24
crPad = nil
iterator = 9
numChildrenRC = 1
userSize = 380
dynamicSize = 38
(for generator) = defined =[C]:-1
(for state) =
1 = "AltoholicMinimapButton"
2 = "GameTimeFrame"
3 = "LibDBIcon10_AskMrRobot"
4 = "LibDBIcon10_BugSack"
5 = "LibDBIcon10_Details"
6 = "LibDBIcon10_Hekili"
7 = "LibDBIcon10_MethodRaidTools"
8 = "LibDBIcon10_O Item Level"
9 = "MiniMapMailFrameDisabled"
10 = "MinimapButtonFrameDragButton"
}
(for control) = 9
i = 9
buttonName = "MiniMapMailFrameDisabled"
miniButton = MiniMapMailFrameDisabled {
0 =
MBFbTex = MBFBackground {
}
MBFoTex = MBFOverlay {
}
}
(*temporary) = defined =[C]:-1
(*temporary) = MiniMapMailFrameDisabled {
0 =
MBFbTex = MBFBackground {
}
MBFoTex = MBFOverlay {
}
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = "MiniMapMailFrame"
(*temporary) = false
(*temporary) =
1 = "MetamapButton"
2 = "QueueStatusMinimapButton"
}
(*temporary) = 2
(*temporary) = nil
(*temporary) = "attempt to index global 'MiniMapMailFrame' (a nil value)"
sortChildren = defined @MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1691
Any plans to make this available for classic
As my title asks since you are not the original author and i'm not sure if you want to take the time it would entail to make the modification to make this compatible with WOTLK classic. Should you decide to go forward with doing so i know there are many myself among them who would be very grateful. I had used MMBF as my main source of button management from its inception until i quite playing about the same time it became abandoned by its original author.
MBF isn't picking up icon for DEJUNK
I'm not sure if this needs to be filed as an issue here or over with DEJUNK, but I figured since I'd start here, since it's MBF's role to "pickup icons".
Specifically, it looks like MBF is detecting the DEJUNK icon, as in my setup, it's giving it the square icon profile I prefer. But MBF doesn't seem to want to keep it in the frame, even though there's clearly a spot for it (see second screen cap, second row, middle icon)
v.2.0.1 is treating the tomtom waypoints and arrows, as an icon
I just did the manual install of v2.0.1, and things are looking solid.
I even got back my "square tokens" that I was using prior to the "fanfix hack" I did.
Thank you!!!
One observation about the latest update, there's a weird incompatibility with TomTom.
the TomTom arrow and waypoints which are normally shown in the minimap, are getting picked up by MBF-R.
In the minimap, they look to have squares on them, and when MBF-R can snag the icons, they'll show up as "buttons" in the MBF-R frame.
(I'll post screen caps in the next comment)
Issues in V10.0 - Dragonflight pre-patch
In WoW v10.0 MinimapButtonFrame is no longer working. The window does not contain any buttons (see attachment) and bug grabber is getting the following errors:
7x Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.xml:9 Unrecognized XML: EdgeSize
7x Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.xml:8 Unrecognized XML attribute: tile
7x Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.xml:8 Unrecognized XML attribute: edgeFile
7x Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.xml:8 Unrecognized XML attribute: bgFile
8x Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.xml:8 Unrecognized XML: Backdrop
Chat commands don't work
Cannot use chat commands to remove buttons gathered. Like the Covenant Sanctum/BFA Mission Board/ Legion Class Hall/ Garrison button. Same button for 4 xpacs but cannot be removed.
Lua error, broken on wotlk classic
using 2.0.5 on the newest wotlk classic build 3.4.1
Message: .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:273: attempt to index field 'ZoomIn' (a nil value)
Time: Tue Jan 17 17:49:33 2023
Count: 1
Stack: .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:273: attempt to index field 'ZoomIn' (a nil value)
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:273: in main chunk
Locals: LibStub =
{NewLibrary = defined @Interface/AddOns/AtlasLootClassic/Libs/LibStub/LibStub.lua:20
minors =
}
minor = 2
IterateLibraries = defined @Interface/AddOns/AtlasLootClassic/Libs/LibStub/LibStub.lua:46
GetLibrary = defined @Interface/AddOns/AtlasLootClassic/Libs/LibStub/LibStub.lua:36
libs =
}
}
L =
Sort By Rows = "Sort By Rows"
ICONADDTITLE_DESC = "Add Protected Item"
OVERRIDEDESC_DESC = "Buttons the MBF thinks are Minimap Icons but are really buttons."
Collect Button = "Collect Button"
No Parent = "No Parent"
debug = "debug"
MBFANCHOR_DESC = "The corner of the MBF window that the frame will grow from."
Nothing = "Nothing"
CURRENTEXCEPTIONS_DESC = "Current Protected Items exceptions"
Alphabetical = "Alphabetical"
MBF_SLASH_Detail6 = "show - Shows the main MBF screen."
Bottom Right = "Bottom Right"
MBF_SLASH_Detail5 = "config - Shows the configuration screen."
Parent = "Parent"
Display Settings = "Display Settings"
OPACITY_DESC = "Set the opacity of the frame."
BUTTONTEXT_DESC = "Text to show on button"
MBF_ERR6 = "Button not ready to be added. Please Retry."
UP = "UP"
MBF_ERR2 = "Only buttons on the MinimapButtonFrame can be removed from it."
MBF_TOOLTIP_ROLLUP = "Left-Click + drag to move MBF
Right-click to Hide/Show the frame"
MBF_ERR4 = "Cannot add. Protected or already included!"
Exclude Queue Button = "Exclude Queue Button"
Unnamed Object = "Unnamed Object"
MBF_SLASH_Detail3 = "remove - removes a gathered button from the frame"
Display = "Display"
Grow Buttons Up = "Grow Buttons Up"
No New Mail = "No New Mail"
UP_DESC = "Move the selected minimap button's order up"
MBF_ERR5 = "Error Removing Child Events from storage."
Opacity = "Opacity"
Top Right = "Top Right"
remove = "remove"
ZOOM_DESC = "Hide the Blizzard Minimap Zoom Buttons"
Gathering Settings = "Gathering Settings"
VOICECHAT_DESC = "Hide the Blizzard Voice Chat Button"
MBF_TOOLTIP_FULL = "Left-Click to Hide/Show the frame
Shift-click to show the config screen
Right-click + drag to move the button"
Hide World Map = "Hide World Map"
TRACKING_DESC = "Hide the Blizzard Tracking Button"
COLLECT2_DESC = "Collect the Blizzard Minimap Buttons"
LOCKED_DESC = "Toggles whether the MBF frame is locked."
All = "All"
ICONADD_DESC = "The generalized name of the Item to be protected."
Sorting Settings = "Sorting Settings"
MBF_TOOLTIP_SMALL = "Shift-click to show the config screen"
GATHERDESC2_DESC = "Settings for the Blizzard Minimap Buttons"
Button Override = "Button Override"
WORLDMAP_DESC = "Hide the Blizzard World Map Button"
DRAGLOCKED_DESC = "Prevent the button and frame from being moved."
ICONREMOVE_DESC = "Removes the selected Protected Item from the exceptions"
Show Minimap Button = "Show Minimap Button"
SHOWBUTTON_DESC = "Show the MBF Minimap Button."
COLOR_DESC = "Chooses the background color for MBF."
MBF_SLASH_Detail8 = "reload - Re-applies the texture. This fixes the blackend icons."
MBF_ERR1 = "Error Removing Button from Storage"
Hide when Locked = "Hide when Locked"
Exceptions Settings = "Exceptions Settings"
MBF Anchor = "MBF Anchor"
ALTTITLE_DESC = "Alt Title Bar Location"
MBF_ERR7 = "Button or Object does not exist."
Blizzard = "Blizzard"
CALENDAR_DESC = "Hide the Blizzard Calendar Icon"
Hide Tracking = "Hide Tracking"
GATHERDESC1_DESC = "Settings for the MBF Minimap Button"
MBF_LDB_TOOLTIP = "Left-Click to Hide/Show the frame
Shift-click to show the config screen"
GROWUP_DESC = "Fills the frame with buttons from the bottom up."
Protecte
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.