ketrel / minimapbuttonframe-redux Goto Github PK

Copied from a comment on a separate issue

          Here's what I'm getting

1x .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1: bad argument #1 to 'GetAddOnMetadata' (Invalid AddOn name MinimapButtonFrame. - Usage: local value = C_AddOns.GetAddOnMetadata(name, variable))
[string "=[C]"]: in function `GetAddOnMetadata'
[string "@MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1: in main chunk

Locals:
(*temporary) = "MinimapButtonFrame"
(*temporary) = "Version"
(*temporary) = "Invalid AddOn name MinimapButtonFrame. - Usage: local value = C_AddOns.GetAddOnMetadata(name, variable)"

1x ...ceMinimapButtonFrameRedux_SkinPack/Skins.lua:5: attempt to call global 'MBFAddSkin' (a nil value)
[string "@MinimapButtonFrameRedux_SkinPack/Skins.lua"]:5: in main chunk

Locals:
(*temporary) = nil
(*temporary) = "Hello Kitty"
(*temporary) = "Interface\AddOns\MinimapButtonFrameRedux_SkinPack\Textures\HKittyActive.tga"
(*temporary) = "Interface\AddOns\MinimapButtonFrameRedux_SkinPack\Textures\HKittyActiveBackdrop.tga"
(*temporary) = 35
(*temporary) = "attempt to call global 'MBFAddSkin' (a nil value)"

Originally posted by @Tetsemi in #15 (comment)

Hello!
I'm the developer of the addon RareScanner, and another user made me the question: "How can I add your minimap button to
Minimap Button Frame Redux", so I tried to follow your tutorial in the description of CurseForge, and I couldn't achieve it, so I checked your code and this is what I found:

1. There is an error parsing the input if you don't use english, for example:
   In english:
   /MBF ADD LibDBIcon10_RareScannerMinimapIcon
   In spanish:
   /MBF añadir LibDBIcon10_RareScannerMinimapIcon
   It doesn't seem to like the letter "ñ", so in your function ChatCommand this doesn't work as intended:
   #855. local startPos, endPos, firstWord, restOfString = strfind(input, "(%w+)[%s%p]*(.*)");
#856. firstWord = strlower(firstWord)
   firstWord takes the value "a", instead of "añadir", so the command doesn't do anything at all.
   restOfString takes the value "ñadir LibDBIcon10_RareScannerMinimapIcon
   I imagine that you will have the exact same problem with russian, chinesse and other localizations where they have their own letters as spanish (suggestion: don't traslate the commands).

2. Once I figured that out, I tried to modify the code and check if I could add my button, however the method isValidAdd doesn't seem to like my button. I saw that you match the frames name with a table of values, and like my addon isn't in that list it doesn't return it as a valid candidate. Am I missing something?

Cheers.

I haven't quite figured out what's causing this, but this error is being thrown in my LUA error trapper.

Message: bad argument #2 to '?' (Usage: self:SetParent([parent]))
Time: Mon Oct 31 10:00:19 2022
Count: 1
Stack: bad argument #2 to '?' (Usage: self:SetParent([parent]))
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `SetParent'
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1538: in function `restoreButtonSettings'
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1611: in function `removeInvisible'
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1689: in function <.../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1673>
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1749: in function `updatePositions'
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1844: in function `?'
[string "@Interface/AddOns/AnnounceRare/Libraries/Ace3/AceTimer-3.0/AceTimer-3.0.lua"]:55: in function <...nceRare/Libraries/Ace3/AceTimer-3.0/AceTimer-3.0.lua:50>

Locals: 

Here's a LUA error being thrown in the latest version of MBF-Redux (2.0.3). The latest Ace3 for 10.0.0 is installed.

7x .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1935: attempt to index global 'MinimapZoomIn' (a nil value)
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1935: in function `MBFC_KeepBlizzHidden'
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1838: in function `?'
[string "@Interface/AddOns/Ace3/AceTimer-3.0-17/AceTimer-3.0.lua"]:55: in function <Interface/AddOns/Ace3/AceTimer-3.0/AceTimer-3.0.lua:50>

Locals:
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index global 'MinimapZoomIn' (a nil value)"

Since the API has changed, I believe there are changes to MinimapZoomIn, MinimapZoomOut, MiniMapMailFrame, MiniMapBattlefieldFrame, etc. (most buttons have been moved to the Minimap namespace, e.g. Minimap.ZoomIn, Minimap.ZoomOut, etc.)

The show/hide state of MinimapButtonFrame appears to be saved across sessions in bachMBF.db.profile.mbfHidden

During login, in the function bachMBF:Init(), it does initially check bachMBF.db.profile.mbfHidden and hides MinimapButtonFrame accordingly (MinimapButtonFrameRedux.lua lines 848-849)

However it then calls function MBFC_RollUp() with a parameter of 1 or 2 based on saved value bachMBF.db.profile.rollUp (lines 852-855)

MBFC_RollUp() overrides bachMBF.db.profile.mbfHidden and changes the show/hide state of MinimapButtonFrame (lines 2022-2023 & 2030-2031), effectively based on the value of bachMBF.db.profile.rollUp

The end result is that the saved value of bachMBF.db.profile.mbfHidden always gets overridden and ignored, and the show/hide state of MinimapButtonFrame does not get correctly restored on login/reload.

It seems stuck up in the minimap. I seem to recall there being a way to force thing, but can't seem to recall the instructions.. Any thoughts?

Currently Ace3 isn't updated for DF—the current version is 9.2.7. This doesn't seem to be causing any issues (yet, at least I don't think so) but I'm wondering if it's fully required to run MBF properly, or if there's an alternative in case it doesn't get updated.

A lot of my mods are still pretty borked from the 10.0 changes so I've been going through and trying to get rid of anything I don't absolutely need. Thank you

Message: .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1826: attempt to index global 'MiniMapMailFrame' (a nil value)
Time: Sun Feb 5 19:10:09 2023
Count: 1
Stack: .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1826: attempt to index global 'MiniMapMailFrame' (a nil value)
[string "=[C]"]: ?
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1826: in function updatePositions' [string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1862: in function ?'
[string "@Interface/AddOns/Ace3/AceTimer-3.0/AceTimer-3.0.lua"]:55: in function <Interface/AddOns/Ace3/AceTimer-3.0/AceTimer-3.0.lua:50>

Locals:

Not sure if it is Minimap button or Ace 3 problem. I just downloaded the latest Minimap zip file before getting this.

• The new tracking icon is not being collected by MBF

The "hide tracking" option also does not seem to work.

• Zoom buttons are not displayed on minimap no matter if "Hide Zoom Buttons" option is enabled or not
• The calendar icon has a ring around it, and since the design of it has changed to square, it can probably be excluded from the decoration or somehow rescaled:

Thank you for all your work!

The border for minimaps appears to be forced to show by MMBF. I use Sexymap to change my minimap to a square layout, while hiding the default border. When MMBF is on, it forces the border to always show despite this.

Reproduction:
Enable Sexymap, go to options - borders, check "Hide default border". Border is hidden as expected.
Enable MMBF - border now always shows
Disable MMBF - border is back to being hidden.

2x .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:1826: attempt to index global 'MiniMapMailFrame' (a nil value)
[string "@MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1826: in function updatePositions' [string "@MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:1862: in function ?'
[string "@DataStore/libs/AceTimer-3.0-17/AceTimer-3.0.lua"]:55: in function <DataStore/libs/AceTimer-3.0/AceTimer-3.0.lua:50>

Locals:
processMail = false
childExceptions = 2
avgButtonSize = 38
spacer = 19
x = 328
y = -24
crPad = nil
iterator = 9
numChildrenRC = 1
userSize = 380
dynamicSize = 38
(for generator) = defined =[C]:-1
(for state) =

As my title asks since you are not the original author and i'm not sure if you want to take the time it would entail to make the modification to make this compatible with WOTLK classic. Should you decide to go forward with doing so i know there are many myself among them who would be very grateful. I had used MMBF as my main source of button management from its inception until i quite playing about the same time it became abandoned by its original author.

I'm not sure if this needs to be filed as an issue here or over with DEJUNK, but I figured since I'd start here, since it's MBF's role to "pickup icons".

Specifically, it looks like MBF is detecting the DEJUNK icon, as in my setup, it's giving it the square icon profile I prefer. But MBF doesn't seem to want to keep it in the frame, even though there's clearly a spot for it (see second screen cap, second row, middle icon)

I just did the manual install of v2.0.1, and things are looking solid.
I even got back my "square tokens" that I was using prior to the "fanfix hack" I did.
Thank you!!!

One observation about the latest update, there's a weird incompatibility with TomTom.
the TomTom arrow and waypoints which are normally shown in the minimap, are getting picked up by MBF-R.

In the minimap, they look to have squares on them, and when MBF-R can snag the icons, they'll show up as "buttons" in the MBF-R frame.

(I'll post screen caps in the next comment)

In WoW v10.0 MinimapButtonFrame is no longer working. The window does not contain any buttons (see attachment) and bug grabber is getting the following errors:

7x Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.xml:9 Unrecognized XML: EdgeSize

7x Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.xml:8 Unrecognized XML attribute: tile

7x Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.xml:8 Unrecognized XML attribute: edgeFile

7x Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.xml:8 Unrecognized XML attribute: bgFile

8x Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.xml:8 Unrecognized XML: Backdrop

Cannot use chat commands to remove buttons gathered. Like the Covenant Sanctum/BFA Mission Board/ Legion Class Hall/ Garrison button. Same button for 4 xpacs but cannot be removed.

using 2.0.5 on the newest wotlk classic build 3.4.1

Message: .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:273: attempt to index field 'ZoomIn' (a nil value)
Time: Tue Jan 17 17:49:33 2023
Count: 1
Stack: .../MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua:273: attempt to index field 'ZoomIn' (a nil value)
[string "@Interface/AddOns/MinimapButtonFrameRedux/MinimapButtonFrameRedux.lua"]:273: in main chunk

Locals: LibStub =