Giter Club home page Giter Club logo

portfolio's Introduction

My Portfolio

This is my portfolio.

screenshot

Built With

  • HTML
  • CSS
  • Linters

Live Demo

Live Demo Link

Getting Started

To get a local copy up and running follow these simple example steps. 1- Click on Code button. 2- Choose Download ZIP button.

Authors

๐Ÿ‘ค Kerolous Samy

๐Ÿ‘ค vechicin

๐Ÿค Contributing

Contributions, issues, and feature requests are welcome!

Feel free to check the issues page.

Show your support

Give a โญ๏ธ if you like this project!

Acknowledgments

  • Hat tip to anyone whose code was used
  • Inspiration
  • etc

๐Ÿ“ License

This project is MIT licensed.

portfolio's People

Contributors

keroloussamy avatar vechicin avatar lucas-masaba avatar iwillteixeira avatar

Stargazers

Oybek Kayumov avatar Angela Cuahutle avatar Humaira Zaman avatar

Watchers

James Cloos avatar  avatar

portfolio's Issues

Missing alt text for images in index.html

Issue with code. The portfolio missing content to alt="";

Suggestion, make the alt description so that it's clear what the image is about.

In your style.css you have to place border-radius: 24px; on line #84

Peer-to-peer review comments

Job well done for an amazing project. Maybe you can just improve the following

  • The JS code that opens and closes the menu, you have a 3 separate classes that you put on the nav items. This can be solved with one class selector only. It will help reduce the amount of code and make your code more readable and shorter.
  • The hamburger menu can remain fixed so that a user can have access to it from anywhere on the website. This will prevent them to scroll up if they need to access other parts of the website.
  • Great work and beautiful project, I think when opening the menu does not cover all cards.

Bugs seek

Bugs fix

File app.js

  • Line 38, add a comma (,).

image

  • Line 110 add() after function name.
    image

-Line 143 Add = () after function name.
image.

Peer-to-peer code review Week2 Day 5

๐Ÿ‘‹ Kero

During our call this morning, we review your code and here are the issues we pointed out ?

  1. You do not need to repeat CSS rules on media queries if they are the same as the parents

Anything else looks great

Good JOB !!!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.