The moviegallery from kenlaam

moviegallery's People

Contributors

Watchers

moviegallery's Issues

Thanks!

Hi, Vũ
Nice job with the assignment 👍

You have learned how to use basic components in React Native. You also spent lots of time for this assignment. What are the obstacles did you have when doing this assignment?

Good point:

You used LayoutAnimation in Movie Detail. That's brilliant. There are many ways to animate in React Native you can try such as Animated, Animatable (https://github.com/oblador/react-native-animatable)
You used onEndReached to fetching data next page 👏. But the data from API does not correct, it's duplicated with the previous page.

Improvements:

Description in ListView's item does not expand based on the content because of numberOfLines={4}
You can use await to replace Promise to make your code cleaner.
From

_fetchData() {
        StatusBar.setNetworkActivityIndicatorVisible(true);
        return fetch(this.state.url + this.state.page)
            .then((response) => response.json())
            .then((responseJson) => {
                this.setState({
                    page: this.state.page++,
                    movieList: this.state.movieList.concat(responseJson.results),
                    movieDS: this.state.movieDS.cloneWithRows(this.state.movieList.concat(responseJson.results)),
                    refreshing: false,
                });
                StatusBar.setNetworkActivityIndicatorVisible(false);
            })
            .catch((error) => {
                console.error(error);
            });
    }

async _fetchData() {
      StatusBar.setNetworkActivityIndicatorVisible(true);
      try {
        const response = await fetch(this.state.url + this.state.page)
        const responseJson = await response.json();
        this.setState({
          page: this.state.page++,
          movieList: this.state.movieList.concat(responseJson.results),
          movieDS: this.state.movieDS.cloneWithRows(this.state.movieList.concat(responseJson.results)),
          refreshing: false,
        });
        StatusBar.setNetworkActivityIndicatorVisible(false);
      } catch (error) {
        console.error(error);
      }
    }

One more thing, how do you feel when working on React Native compared with Android Native?

Recommend Projects