Comments (4)
sdogruyol
commented on June 9, 2024
1
Looks like a bug to. me, thanks a lot for reporting @syeopite I'll put this as priority in my pipeline 👍
from kemal.
sdogruyol
commented on June 9, 2024
My initial findings show that Kemal::Config::INSTANCE.handlers is not working as expected. Instead of respecting Kemal::Config::FILTER_HANDLERS it just errors out flat. Changing the order of the filters didn't work either. Need to investigate if it's a special behavior to 404
from kemal.
grkek
commented on June 9, 2024
My initial findings show that
Kemal::Config::INSTANCE.handlersis not working as expected. Instead of respectingKemal::Config::FILTER_HANDLERSit just errors out flat. Changing the order of the filters didn't work either. Need to investigate if it's a special behavior to404
Might be the exception handler short-circuiting the response and ignoring filter handlers
from kemal.
jpmartinspt
commented on June 9, 2024
It seems, like the filter handler does not get the blocks if a route is not found?
kemal/src/kemal/filter_handler.cr
Line 16 in cb9adcd
Commenting that line seems to make the original example work, but from a quick search I could not find the reasoning for it to be there in the first place. Happy to try and put in a PR to fix if you give some pointers on why it's there.
from kemal.
Related Issues (20)
- When use content_for with yield_content, output duplicate page content. HOT 9
- [Question] What is the correct way to share a object(e.g. current_user) across kemal session HOT 3
- before_all can not intercept http processing use env.redirect "new_path" HOT 13
- Internal API broken in Crystal nightly
- Logs are messed up in multithreaded mode HOT 2
- build failed with latest crystal HOT 5
- Error: undefined method 'modification_time' for Kemal::StaticFileHandler (Crystal 1.6.0) HOT 2
- Compilation issue with crystal 1.6 HOT 4
- Problem serving local files HOT 5
- MacOs Ci is broken HOT 5
- A simple hello world kemal app run on windows failed. (but compilation on github action successful) HOT 1
- StaticFileHandler doesn't work on Windows HOT 1
- Kemal won't clean up broken file uploads HOT 2
- Adding Handlers HOT 2
- bug:Unhandled exception: Not Implemented: Crystal::System::Signal.trap (NotImplementedError) from D:\Dev\Crystal\src\crystal\system\win32\signal.cr:5 in 'trap' HOT 2
- Date Header Missing from Kemal HOT 2
- a list of all configured routes? HOT 1
- Error page doesn't (re)set content_type HOT 2
- Filters being called regardless the path specified
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kemal.