Comments (5)
It works if public_folder
function is used instead of setting in config. Will try to dig more and get the exact reason for this. For now you can try
require "kemal"
IP = "127.0.0.1"
PORT = 8081
Kemal.config.port = (ENV["PORT"]? || PORT).to_i
Kemal.config.host_binding = ENV["HOST_BINDING"]? || "#{IP}"
# Kemal.config.env = "production"
public_folder "dist"
Kemal.run do |config|
# other configs ...
end
from kemal.
Hi @serge-hulne . Please re-open the issue. It's just a workaround.
This code is not working as expected::
Kemal.run do |config|
config.public_folder = "dist"
end
The original issue can be fixed in Kemal by placing yield config
right above config.setup
here:
https://github.com/kemalcr/kemal/blob/master/src/kemal.cr#L32-L47
/cc @aravindavk
from kemal.
@aravindavk nope. Please check if it actually fixes the issue. Because I'm not sure. And create PR. Thanks.
from kemal.
Thank you!
from kemal.
The original issue can be fixed in Kemal by placing yield config right above config.setup here:
Thanks for the pointer. Are you planning to send the fix, or shall I send?
from kemal.
Related Issues (20)
- Slang doesn't render anymore HOT 10
- When use content_for with yield_content, output duplicate page content. HOT 9
- [Question] What is the correct way to share a object(e.g. current_user) across kemal session HOT 3
- before_all can not intercept http processing use env.redirect "new_path" HOT 13
- Internal API broken in Crystal nightly
- Logs are messed up in multithreaded mode HOT 2
- build failed with latest crystal HOT 5
- Error: undefined method 'modification_time' for Kemal::StaticFileHandler (Crystal 1.6.0) HOT 2
- Compilation issue with crystal 1.6 HOT 4
- MacOs Ci is broken HOT 5
- A simple hello world kemal app run on windows failed. (but compilation on github action successful) HOT 1
- StaticFileHandler doesn't work on Windows HOT 1
- Kemal won't clean up broken file uploads HOT 2
- before_all handler isn't called for error routes HOT 4
- Adding Handlers HOT 2
- bug:Unhandled exception: Not Implemented: Crystal::System::Signal.trap (NotImplementedError) from D:\Dev\Crystal\src\crystal\system\win32\signal.cr:5 in 'trap' HOT 2
- Date Header Missing from Kemal HOT 2
- a list of all configured routes? HOT 1
- Error page doesn't (re)set content_type HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kemal.