keltia / dices-rs Goto Github PK

We need to implement completion.

Dices> mouv
INFO - roll = Res { list: [3, 3, 1], sum: 5, bonus: -2, flag: None }

We can do better.

doom is a real command but doesn't need to. Handle real aliases stored in a aliases file store along the history.

If we have an alias pointing to a new command or another alias, the parser is re-entered once but not twice. Make it recursive somehow?

If you run open d4 +1, bonus is not taken into account.

The current move command is currently fixed, it should take a bonus argument.

The current system duplicate code between Dice::roll() and DiceSet::roll(). There is also interaction between each Dice and Result.

While doing the sum, it does not take into account the bonus/malus.

main() currently does too many things and knows about Engine internals. Fix it.

You can probably easily make the parser blow up with defining an alias pointing to another one which points to the first one. We should limit recursion to something sensible like 5.

There is Command::execute() which deals with builtin commands (like dice and open) but all the other commands are handled in Engine or directly in main(). This should me fixed.

When parsing new commands, we recurse into the parser until we reach to a Builtin or Alias. Argument to the previous level need to be concatened to the new input so in the lowest level, dice/open need to accept multiple "+/- int".

We can not have quit = exit because exit is not a Cmd. mouv = move +è because it compiles to dice. Still having aliases to Commnad would be nice.