kellysutton / ember-number-to-human-size Goto Github PK

Hi, @kellysutton.
Thanks for your good addon!
Would you be interested in a PR with helper that takes value, its current units and convert it to the another units?
Example:

{{number-to-fixed-size 1024 false 0 KB MB}} {{! prints "1 MB" }}
{{number-to-fixed-size 1 false MB KB}} {{! prints "1024 KB" }}

If it is interesting to you let me know - I'll start work on PR.
number-to-fixed-size - please select appropriate one. Arguments order may be discussed too.

Ember logs the following deprecation warning:

`Ember.HTMLBars.makeBoundHelper` is deprecated. 
 Please refactor to using `Ember.Helper` or `Ember.Helper.helper`.

Maybe something like this for backwards compatibility:
https://github.com/stefanpenner/ember-inflector/blob/bdb4165206c9fea9b27b3bb961d9b4885cee1a6c/addon/lib/utils/make-helper.js

I get this deprecation warning when I run ember serve, (or just ember --version):

ember --version
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: bbcpe -> ember-number-to-human-size -> ember-cli-babel
ember-cli: 3.3.0
node: 8.11.1
os: linux x64

Hi, I'm attempting to upgrade an Ember app to Ember and ember-cli 3.5, and the following error is now happening:

Uncaught Error: Could not find module ember imported from ember-number-to-human-size/utils/make-helper at http://localhost:7357/assets/vendor.js, line 252

I noticed this with some other libraries as well.

Is Ember 3.5 supported? Thanks