kelin2025 / effector-factorio Goto Github PK

Hi. Why model prop is passed to original view component?
This is needed only for types?
Because I wasn't expected to receive it alongside with my component props.

const FeatureComponentSelect = modelView(factory, (props: SelectProps) => { const model = factory.useModel(); // some code inside return <Select {...props} /> })

So in the DOM I have model prop passed.
So this is a problem, and I need somehow to make 2 steps to solve this issue

1. every type of component wrapper I need to mix to something like this
   props: SelectProps & { model: ReturnType<typeof factory.useModel> }
2. if component passed rest props with spread, every time you need to extract model prop from it

So, my question is - why you pass model prop to original component if you never use it (model is always is extracted through factory.useModel hook)

My suggestion is to separate viewProps from model like this

 const { model, ...viewProps } = props;

Привет. Возник вопрос по тому, какие best practices есть по использованию effector-factorio вместе с effector/babel-plugin, чтобы проставлялись sid юнитам. Если условно у меня есть папка features и в каждой фиче есть фабрика.

Since tsdx does not support "jsx": "react-jsx" in tsconfig.json, I transpile it with babel
However, Vite says React is not defined
To fix this, you can add this to vite.config.ts:

// vite.config.js
import { defineConfig } from 'vite'

export default defineConfig({
  esbuild: {
    jsxInject: `import React from 'react'`
  }
})

But we need to fix it anyway

https://effector.dev/docs/ecosystem-development/unit-shape-protocol

Looks like it would be very useful to use this protocol with useUnit:

const formFactory = modelFactory((options: FactoryOptions) => {
  const loginChanged = createEvent<string>();
  const passwordChanged = createEvent<string>();
  const submitPressed = createEvent();

  const $login = createStore('');
  const $password = createStore('');

  const $form = combine({ login: $login, password: $password });

  const $disabled = options.registerFx.pending;

  $login.on(loginChanged, (prev, next) => next);
  $password.on(passwordChanged, (prev, next) => next);

  sample({
    source: $form,
    clock: submitPressed,
    target: options.registerFx,
  });

  return {
    $login,
    $password,
    $disabled,
    loginChanged,
    passwordChanged,
    submitPressed,
  };
});

const form = formFactory({ registerFx })

function App() {
  const { login, password, disabled, loginChanged, passwordChanged, submitPressed } = useUnit(form)
}

But I think it will be very useful to remove $ from the prefix.