Not able to create instance group using latest release (0.5.0) and the provided sample yaml spec about instance-manager HOT 5 CLOSED

@darrendao
I think you need to update your CRD since we changed some types to pointers - there were CRD changes with this release.

Our nightly functional tests are passing here:
https://travis-ci.org/github/keikoproj/instance-manager/builds/667478575

Some of these types were made into pointers so that we can take advantage of omitempty
Otherwise for example you can end up with a spec that looks like this:

apiVersion: instancemgr.keikoproj.io/v1alpha1
kind: InstanceGroup
metadata:
  annotations:
  name: hello-managed
  namespace: instance-manager
spec:
  provisioner: eks-managed
  strategy:
    type: managed
  eks-cf: {}   <-- not omitted
  eks-managed:
    configuration:
      < .. >
    maxSize: 6
    minSize: 3

from instance-manager.

@eytan-avisror I got the error on a fresh K8S setup using the latest CRD provided in https://github.com/keikoproj/instance-manager/blob/master/docs/04_instance-manager.yaml (per instructions in the docs).

from instance-manager.

I see, our tests are running with this struct populated:

rollingUpdate:
      maxBatchSize: 1
      minInstancesInService: 1
      minSuccessfulInstancesPercent: 100
      pauseTime: PT2M

so it's possible that this is why we're not seeing it.
I guess what we should do here is set default values in the controller if this struct is unset - this is a required struct and we should probably also add it to the examples as it defines the configuration of the rollingUpdate, we should not be omitting it.

from instance-manager.

@darrendao let me know if you want to work on it, otherwise will prioritize this for next release

from instance-manager.

closing this since we will be deprecating eks-cf provisioner in favor of new one.
we will make sure this is addressed in the new provisioner via spec validation / setting defaults / validating webhooks.
This will be part of #50

from instance-manager.