Giter Club home page Giter Club logo

Comments (3)

shrinandj avatar shrinandj commented on September 27, 2024

Can you check if the LaunchConfig/LaunchTemplate created by the instance-manager? Does it show the spot price being set?

from instance-manager.

eytan-avisror avatar eytan-avisror commented on September 27, 2024

There might be a problem the with setting of lifecycle=spot in this case. I think the current logic depends on whether a spot price is set or not, and not whether instances are actually switched to spot.
In the case of using spot recommendations with minion manager that works fine since the price is available, but if someone just sets a spotPrice which is not available the result would be lifecycle=spot and it cannot switch because the price is not available.

My recommendation for now is to either use spot recommendations via minion-manager or switch to spot via LaunchTemplate/Mixed Instance Policies which is a more automated mechanism via AWS.

https://github.com/keikoproj/instance-manager/blob/master/docs/EKS.md#spot-instances

Leaving this ticket open so we can look into better logic around manually setting spotPrice

from instance-manager.

amandre avatar amandre commented on September 27, 2024

Thank you guys for your thoughts!
Yes, it worked with MixedInstancePolicies or with minion-manager but was curious if it is expected to work for spotPrice.
I'll gladly collaborate and help in introducing a better logic here (or at least fixing the documentation explaining the desired logic).

from instance-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.