keeporsweep / keeporsweep-desktop Goto Github PK

Currently we simply check the extension (.png, .jpg, .jpeg or .gif), and this seems to be better: https://pillow.readthedocs.io/en/3.1.x/handbook/tutorial.html#identify-image-files

The »Sweep« button is not functional at the moment. It’s probably simple to implement, but we should make sure they are moved to the system trash instead of permanently deleted.

There should be a nice and rewarding counter somewhere which counts up how much you sweep. :)

Could be for example right of the sweep button.

I wanted to start this with Kivy, but it apparently seemed to be broken on Ubuntu 17.10: kivy/kivy#5453

But Kivy seems much better than tkinter for our specific case:

• It seems it has better support for animations
• It also is targeted towards touch interfaces (for possible swiping)
• Additionally works for Android

Just like in the Nextcloud app, we should show an empty state when all the files are through. Something like this:

• Showing the emptycontent message
• Disabling the buttons
• Converting the "Keep" button into a "Reload"/"Shuffle" button

Currently when there are long file names or directories, the window will become wider. As a result the Keep/Sweep buttons move and that’s quite annoying.

Steps to fix this:

• Limit the container width
• Ellipsize from a certain width (some searching revealed that this might only be possible to limit by number of characters)
• Middle-ellipsize the text (possible in Kivy at least)

So we are starting again after a long time

In my last PR, I attempted to fix a few bugs PR#17

Rewriting them here:

Added deletion counter to fix issue #9
Added image for empty state to fix issue #6
Added preview for text files to fix a few things in issue #1

The updates regarding them

1. Deletion counter

I added it but due to Tkinter's GUI features, there are only two ways to do that

Image 1
Image 2

I could not find a way to do the Twitter like UI because:

• There can be only one text on the Sweep button
• Text cannot be kept partially bold and "un-bold" in Tkinter.

We need to find a way to do this

2. Image for empty state

We need to do what we did in Twitter, we will have to generate a new image each time there is an empty state. Can use Pillow for that.

[ ] Need to get the template image, if possible. Otherwise, create one

3. Text file thumbnail works, if there is anything to be changed, I can do that otherwise I will create a new PR just for that and then we can merge it.

All the screenshots for above 3 points can be seen in #17

4. Thumbnail for PDF files

I tried to add this for my personal use when I had a lot of PDF files to be removed. I am using Windows so it was a bit hacky, had to install a lot of things. I am not sure how to go about this. Can we discuss about this?

The title is set but the window icon is missing. This Stackoverflow thread should help: https://stackoverflow.com/a/18538416

As we close 3 issues since the last release, we should also publish a new release.
Since pyinstaller's output executable works only on the environment it was developed on, we will need to create executables on different environments and test them.
I can create executables for Windows 10 64-bit and Ubuntu.

Any other suggestions?

Currently only images are shown and the app doesn’t start if the shuffled filelist begins with a non-image.

Steps to take to fix this:

• A first step would be to simply skip non-images
• Show a notice in the interface
• Show the non-images with empty preview box
• Show filetype icons for non-image files
• Show previews for other files where possible. Text files should be easy with canvas too

Seems to be possible with some library: https://stackoverflow.com/questions/26653929/pdf-viewer-for-python-tkinter

For big home folders it can take quite some time to load the whole list of files.

To make this quicker, there’s some options:

• Load the interface first (create_widgets) before the file list creation (random_files) – and move element_preview & element_text out of create_widgets into init
• Show some loading feedback there after the base interface loaded
• Load a few first files quickly, and others in the background (not sure this works)

To check out a bigger view of the file (and others nearby), it would be nice if:

• Clicking on preview and filename opens the file in the proper viewer or app for it
• Clicking the path opens the folder where the file is in, ideally with the file highlighted (if that’s at all possible)