kebablord / teriyaki Goto Github PK

Bugs:

1. Don't use variable without quotes as it can match globbing (files with star, question mark, etc.) and be word splitting (by space tab or new line). -> can't send file with '?*' or 'foo bar' file names
2. Tilde shroud not be in quotes. ..."~/.ssh... even if is just example
3. Use double dash -- for end of argument -> cant send file by giving file name '--help'

use shellcheck for help in fixing most bugs

Highly recommend:

• Don't use eval, it can be made to work by quoting "${1@Q}" , but this only supports newer versions of bash and its better to provide the command instead of eval.

Recommend:

1. Use lower case variable names, this is the convention, upper cased comes from OS and the shell.
2. Use [[ insted of [ as its better syntax allows arguments without quotes