Assert failed caused by timertop plugin about gammaray HOT 8 CLOSED

This looks like an issue in Qt itself. I was able to create a small test program that trips the same assert. I filed a bug on qt-project: https://bugreports.qt-project.org/browse/QTBUG-32501

from gammaray.

Follow up, the folks at qt-project say that setting properties on objects outside of the thread the object lives in is undefined behavior, so the assert is not a bug but works as designed. timertop_plugin should check the timer's thread affinity before trying to set properties on the timers, and if the thread affinity is different from the current thread, either you don't set the property, or come up with a way to do it on the thread the object lives in.

from gammaray.

Yep, the timertop plugin is known to be crashy when it comes to multithreaded applications. How to figure that one out in a proper way is left to be seen.

from gammaray.

Indeed, known issue. The property is used to store internal information of the plugin, a mutex-protected map with the timer pointer as key should allow the same, and fix this.

from gammaray.

Milian, is this fixed by your commit from yesterday?

from gammaray.

Quite possibly so. But I'd like to test it more thoroughly next week before I close this report.

Cheers

from gammaray.

I just tested this on KDevelop, which is heavily multithreaded and reliably crashed GammaRay before. Now it stayed stable so I think we can assume this to be fixed.

Note though that timers in non-main-thread are excluded now. Something for the future.

from gammaray.

So I assume we can close this? Closing.

from gammaray.