Help tools are misdetected on recent Qt version about gammaray HOT 5 CLOSED

@krop Nice catch!

Though, I admit I'm really surprised that "recent Qt6 versions" would even be using the fallback find_program() scanning. Does your install not have the Qt::qhelpgenerator and Qt::qtattributionsscanner CMake targets available?

from gammaray.

@krop Nice catch!

Though, I admit I'm really surprised that "recent Qt6 versions" would even be using the fallback find_program() scanning. Does your install not have the Qt::qhelpgenerator and Qt::qtattributionsscanner CMake targets available?

Check the pull request, there was another issue that has also been fixed.

from gammaray.

@krop

Check the pull request, there was another issue that has also been fixed.

Yeah, I saw that part... I guess it's because the very first Qt probe GammaRay does is for "QT" in all caps:

Because, when I do this:

find_package(Qt 5.5 NAMES Qt6 Qt5 COMPONENTS Core NO_MODULE REQUIRED)

...on Fedora 38, only ${Qt_VERSION_MAJOR} is defined. But when I do this:

find_package(QT 5.5 NAMES Qt6 Qt5 COMPONENTS Core NO_MODULE REQUIRED)

only ${QT_VERSION_MAJOR} is defined. (Pretty strange of Qt to not just set both capitalizations, at least in the find_package(Qt...) scenario.)

from gammaray.

@krop

Check the pull request, there was another issue that has also been fixed.

Yeah, I saw that part... I guess it's because the very first Qt probe GammaRay does is for "QT" in all caps:

Deleted my previous comment. See https://cmake.org/cmake/help/latest/command/find_package.html#full-signature

If the NAMES option is given, the names following it are used instead of <PackageName>.

CMake will search for Qt5Config.cmake, then Qt6Config.cmake.

Since these commits are not part of the 3.0.0 release, can you create a new issue with your findings please? (I'll complete with mines, I see 3 different issues in this code)

from gammaray.

Since these commits are not part of the 3.0.0 release, can you create a new issue with your findings please? (I'll complete with mines, I see 3 different issues in this code)

Correction, they are. I'll submit the report.

from gammaray.