Giter Club home page Giter Club logo

aasm-diagram's People

Contributors

annawinkler avatar aurelien-iapp avatar benjyblack avatar jgrau avatar katee avatar merrington avatar mihaimuntenas avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

aasm-diagram's Issues

add more space to the transition names

Very cool project - I wonder if there's a simple way to adjust the amount of space between the lines and the transition names?

In some diagrams things have looked a bit crowded

maybe just prefix the transition name with a couple of whitespaces?

Does not appear to map transitions of subclass with new states

Given two classes:

class Test
  include ::AASM
  class LocalStatusEnum < EnumerateIt::Base
    associate_values(
      :my_first_state,
      :my_second_state
    )
  end

  class LocalEventEnum < EnumerateIt::Base
    associate_values(
      :my_one_event,
      :my_other_event
    )
  end

  aasm do
    state LocalStatusEnum::MY_FIRST_STATE.to_sym
    state LocalStatusEnum::MY_SECOND_STATE.to_sym

    event LocalEventEnum::MY_ONE_EVENT.to_sym do
      transitions(
        from: LocalStatusEnum::MY_FIRST_STATE.to_sym,
        to: LocalStatusEnum::MY_SECOND_STATE.to_sym
      )
    end
  end
end

and

class TestSub < Test

  aasm do
    state :my_third_state

    event LocalEventEnum::MY_OTHER_EVENT.to_sym do
      transitions(
        from: LocalStatusEnum::MY_SECOND_STATE.to_sym,
        to: :my_third_state
      )
    end

  end
end
require 'aasm-diagram'
test = TestSub.new
AASMDiagram::Diagram.new(test.aasm, 'test.png')

produces

image

even though I can transition to my_third_state:

[3] DEVELOPMENT(main)> test.my_first_state?
=> true
[4] DEVELOPMENT(main)> test.may_my_one_event?
=> true
[5] DEVELOPMENT(main)> test.may_my_other_event?
=> false
[6] DEVELOPMENT(main)> test.my_one_event
=> true
[7] DEVELOPMENT(main)> test.may_my_other_event?
=> true
[8] DEVELOPMENT(main)> test.my_other_event
=> true
[9] DEVELOPMENT(main)> test.my_third_state?
=> true

If I transition to my_second_state BEFORE diagramming, I get the correct diagram

image

Filter State Machine based on Guard Conditions

We wanted to generate the state transition diagram only for 1 of my guard conditions as we have multiple guard conditions and we don't want the diagram for all the guard condition transition.

event :move_to_abc do
        transitions from: :xyz, to: :abc, guards: :guard1?
        transitions from: :mno, to: :abc, guards: :guard2?
        transitions from: :pqr, to: :abc, guards: :guard3?
 end

So we have to generate different diagram for every guards i.e. guard1, guard2, guard3

Feature Proposal: create railtie.rb and make `rake aasm:diagram[ModelName]` command available on rails?

Hi. First, thank you for this great gem.

I thought it would be useful if lib/aasm_diagram/railtie.rb is created, and in there, define the rake task for generating the png file, using the AASMDiagram::Diagram.new(ModelName.new.aasm, Rails.root / (ModelName) + '.png' ). I think the synopsis of such command will be something like: rake aasm:diagram[ModelName]. Since it will be defined as a railtie, those who are not using rails will not be affected.

Any opinion?

If this sounds good, I can implement it and create such PR.

NoMethodError: undefined method `id' for nil:NilClass

2.4.0 :182 > AASMDiagram::Diagram.new(rfq.aasm, 'Bug.png')
NoMethodError: undefined method `id' for nil:NilClass
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/ruby-graphviz-1.2.3/lib/graphviz/edge.rb:196:in `getNodeNameAndPort'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/ruby-graphviz-1.2.3/lib/graphviz/edge.rb:31:in `initialize'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/ruby-graphviz-1.2.3/lib/graphviz.rb:210:in `new'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/ruby-graphviz-1.2.3/lib/graphviz.rb:210:in `add_edges'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/aasm-diagram-0.1.0/lib/aasm_diagram/diagram.rb:30:in `block (2 levels) in draw_edges'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/aasm-diagram-0.1.0/lib/aasm_diagram/diagram.rb:26:in `each'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/aasm-diagram-0.1.0/lib/aasm_diagram/diagram.rb:26:in `block in draw_edges'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/aasm-diagram-0.1.0/lib/aasm_diagram/diagram.rb:25:in `each'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/aasm-diagram-0.1.0/lib/aasm_diagram/diagram.rb:25:in `draw_edges'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/aasm-diagram-0.1.0/lib/aasm_diagram/diagram.rb:15:in `draw'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/aasm-diagram-0.1.0/lib/aasm_diagram/diagram.rb:8:in `initialize'
	from (irb):182:in `new'
	from (irb):182
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/railties-5.0.6/lib/rails/commands/console.rb:65:in `start'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/railties-5.0.6/lib/rails/commands/console_helper.rb:9:in `start'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/railties-5.0.6/lib/rails/commands/commands_tasks.rb:78:in `console'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/railties-5.0.6/lib/rails/commands/commands_tasks.rb:49:in `run_command!'
	from /Users/ahmadyakobbinabaidullah/.rvm/gems/ruby-2.4.0@eproc/gems/railties-5.0.6/lib/rails/commands.rb:18:in `<top (required)>'
	from bin/rails:4:in `require'
	from bin/rails:4:in `<main>'

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.