karthicks / gremlin-ogm Goto Github PK

Hi I'm the author of the Ferma project ( https://github.com/Syncleus/Ferma ).

This project seems to be almost completely redundant of the functionality already present in the Ferma project. The annotation names are a bit different, as are the method calls, but they both seem to be virtually identical in what they are trying to accomplish and how they go about it. Ferma however is more mature so has a much more extensive set of features.

With that said I was wondering if you'd be interested in merging efforts, if there is anything novel in your code I've overlooked I'd love to add that functionality to Ferma and perhaps work together rather than working separately towards the same end goal. Let me know if this would interest you.

How does this handle properties of a Vertex that may contain an Enum type. Since enums can't extend Element I don't see how these can be used within a vertex as a property of it.

One of the concerns that came out of the DISCUSS thread for the pull request for TINKERPOP-1750 was that the gremlin-objects library might run into issues when dealing with a remote traversal, specifically one generated using the graph.traversal().withRemote(...) option. To quote Stephen Mallette, the issue is that "You get back a "reference" vertex which only has
the id and label - no properties."

Given that gremlin-objects terminates the GraphTraversal using either a next or a toBulkSet action, it may be possible that the properties in the resulting vertex does have the properties we need, in which case no changes would be required. If not, then we may need to explicitly ask for each property using the properties or values step, before doing the next or toBulkSet step.

In any case, a test case that addresses this use case is needed, and this issue tracks that effort.

This looks to have promise and I may be doing some graph DB stuff in the future . .