Giter Club home page Giter Club logo

codility's People

Contributors

karimhamdanali avatar wuntenn avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

codility's Issues

solution2 does not return the correct int if list order is changed

If the main has the following code System.out.println(solution(new int[] { 7, 9, 3, 9, 3, 9, 9 })); an incorrect number is returned by solution2.
The below code for solution2 works well and is of same order:

public static int solution2(int[] A) {
	// write your code in Java SE 8
	HashSet<Integer> dups = new HashSet<Integer>();
	ArrayList<Integer> tmp = new ArrayList<>();
	for (int i = 0; i < A.length; i++) {
		if (dups.add(A[i])) {
			tmp.add(A[i]);
		}
		else{
			tmp.remove(new Integer(A[i]));
		}
	}
	return tmp.get(0);
}

solution2 does not returns 7 if the int order is changed

If the main has the following code System.out.println(solution(new int[] { 7, 9, 3, 9, 3, 9, 9 })); an incorrect number is returned by solution2.
The below code for solution2 works well and is of same order:

public static int solution2(int[] A) {
	// write your code in Java SE 8
	HashSet<Integer> dups = new HashSet<Integer>();
	ArrayList<Integer> tmp = new ArrayList<>();
	for (int i = 0; i < A.length; i++) {
		if (dups.add(A[i])) {
			tmp.add(A[i]);
		}
		else{
			tmp.remove(new Integer(A[i]));
		}
	}
	return tmp.get(0);
}

odd number selection bug

Came upon this code through google search

for (int i = 0; i < A.length; i++) {
if (dups.add(A[i])) {
elem = A[i];
}
}
return elem;

If the input array is arranged so that the odd number occurs before the pairs, the output will be the last number did not exist in the set, which may not necessarily be the odd number.
for example, {7, 9, 3, 9, 3, 9, 9} will return 3

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.