Giter Club home page Giter Club logo

Comments (6)

MrNoodle avatar MrNoodle commented on July 17, 2024

I can remove the view reloads (which re-fetches the data). It seems to work fine without them as long as you set the URL/directory next time you use it (which will reload the views), which I think is the normal usage pattern. Should I also reset the directory URL to nil?

from connectionkit.

mikeabdullah avatar mikeabdullah commented on July 17, 2024

I think it seems reasonable to me to keep the directory URL the same as it was before.

I have to admit in our code we're creating a fresh open panel each time, so I haven't looked that much at how that might affect panel re-use.

from connectionkit.

MrNoodle avatar MrNoodle commented on July 17, 2024

Just pushed the fix. Confirm it on your end and close if it works for you.

from connectionkit.

mikeabdullah avatar mikeabdullah commented on July 17, 2024

I fear there's more to it than that. If I:

  1. Bring up the panel
  2. Navigate to a folder
  3. Click OK

I now get this:

#0  0x00007fff906486b3 in objc_exception_throw ()
#1  0x00007fff8dfc174e in -[__NSArrayI objectAtIndex:] ()
#2  0x0000000100927e59 in -[CK2OpenPanelColumnViewController browser:child:ofItem:] at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanelColumnViewController.m:358
#3  0x000000010092797b in __48-[CK2OpenPanelColumnViewController selectedURLs]_block_invoke at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanelColumnViewController.m:300
#4  0x00007fff918bbdec in __NSIndexSetEnumerate ()
#5  0x0000000100927913 in -[CK2OpenPanelColumnViewController selectedURLs] at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanelColumnViewController.m:295
#6  0x00000001009211d1 in -[CK2OpenPanelController validateProgressIndicator] at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanelController.m:800
#7  0x000000010092062a in -[CK2OpenPanelController childrenForURL:] at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanelController.m:671
#8  0x0000000100927e05 in -[CK2OpenPanelColumnViewController browser:child:ofItem:] at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanelColumnViewController.m:352
#9  0x000000010092797b in __48-[CK2OpenPanelColumnViewController selectedURLs]_block_invoke at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanelColumnViewController.m:300
#10 0x00007fff918bbdec in __NSIndexSetEnumerate ()
#11 0x0000000100927913 in -[CK2OpenPanelColumnViewController selectedURLs] at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanelColumnViewController.m:295
#12 0x00000001009211d1 in -[CK2OpenPanelController validateProgressIndicator] at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanelController.m:800
#13 0x00000001009210c7 in -[CK2OpenPanelController validateViews] at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanelController.m:779
#14 0x000000010091f654 in -[CK2OpenPanelController resetSession] at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanelController.m:431
#15 0x000000010091b505 in -[CK2OpenPanel endWithCode:] at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanel.m:223
#16 0x000000010091b902 in -[CK2OpenPanel ok:] at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanel.m:263
#17 0x0000000100921fd9 in -[CK2OpenPanelController ok:] at /Users/Mike/Code/Karelia/Sandvox/Code/ConnectionKit/ConnectionKit/CK2OpenPanelController.m:907
#18 0x00007fff8a062cd7 in _os_activity_initiate ()
#19 0x00007fff90e0f6d7 in -[NSApplication sendAction:to:from:] ()

I've selected item 17 of a particular folder. That's what the browser's data source is being asked for. But at this point in time, it looks the panel has been reset in some fashion, because all that's present in the data source is:

Printing description of children:
(
    "Loading%E2%80%A6"
)

from connectionkit.

MrNoodle avatar MrNoodle commented on July 17, 2024

Ack, you're right. Will take a closer look at it. It probably doesn't need to do anything with the UI really so I'll also defer validating.

from connectionkit.

mikeabdullah avatar mikeabdullah commented on July 17, 2024

Excellent, working a treat for me!

from connectionkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.