New Folder button shouldn’t be enabled until actually connected about connectionkit HOT 12 CLOSED

I'm in two minds about this. Say you are on a slow connection and know you definitely do want to create a new folder. It seems frustrating to have to wait until the folder loads before being able to do that.

If there is a problem like the username or password being wrong, the sheet should be dismissed, rather than hanging. I believe I've now fixed bugs that were causing it to hang around too long.

from connectionkit.

I don’t really understand your point. If you haven’t connected yet, then you haven’t filled in the file browser with any useable information. Without seeing where you are, how/where can you create a new folder? What if your assumptions about the “root” directory are wrong? It makes no sense to me to show two empty windows with an action to perform which can’t (yet) be performed.

from connectionkit.

Perhaps it's best to avoid thinking in terms of "connections" as that's not how CK2 works. Instead, the panel is loading a "request" for a particular folder.

While loading the panel may not know the 'absolute' path, but it does always know the path relative to the home directory at the very least. The location for the new folder to go into matches that.

Maybe I'm not even arguing what we have now is all that much 'better' (I don't feel like you alternative is better either), but it seems perfectly decent, and avoids adding extra state logic to manage.

from connectionkit.

Perhaps it’s best to think about how the user will perceive it rather than how CK2 works?

from connectionkit.

While loading, the user sees a blank file browser, with a spinning progress indicator in the upper right hand corner. I think that's moderately clear "something is happening".

Are you concerned people will click the "New Folder" button in an attempt to speed things up? Or that they might think it's what they're "supposed" to do while it loads?

from connectionkit.

No, I’m saying it seems dumb to have an active New Folder button while the thing is empty but spinning which then brings up a modal window that is also empty but spinning. It seems odd to me to have a button enabled to perform an action than cannot yet be performed and which also provides no context for the action. I understand that the action would theoretically occur at the “root” for the login, but a blank window is a blank window is a blank window. Poor UI in my opinion.

But if you disagree, I’ll move on.

from connectionkit.

To check, that progress indicator only appears one you've hit the "Create" button, right?

from connectionkit.

No, I never said that. You always get two spinning indicators as soon as the window appears on screen. I’ve never clicked on Create. It makes no conceptual sense to do so (is my point).

from connectionkit.

I agree with Terrence on this one. Until the panel is showing something, I think that button should be disabled. It's an easy fix. In -validateNewFolderButton, check if _currentLoadingOperation is nil (meaning that it's not currently in the middle of a loading operation) and enable it then. If you want, I can do the modification though it's going to take me a bit to untangle the forks/branch/repos on my end.

from connectionkit.

See, I definitely think having a progress indicator appear in the New Folder panel before hitting the "Create" button is a bug.

If you favour disabling the "New Folder" button, @MrNoodle, then I'm happy to go along with that. I'd appreciate it if you made that change; no particular rush.

Additionally, it seems to me the path control should get populated with something while the initial load happens.

from connectionkit.

Sorry for taking so long with this. For some reason I thought I'd fixed this a whiles back.

from connectionkit.

👍

from connectionkit.