For the function get_stories, the parameter options 'newest' and 'best' do not work. the reason is because by default the function works for getting only top stories from default page https://news.ycombinator.com/news

I can modify this either by updating the get_stories function or creating separate functions for default, newest and best. The advantage of the latter is that people using the api do not have to pass parameters to get_stories functions every time and they can just call the relevant function; this of course is a disadvantage because alot of code will be re-written. The advantage of the former is less code to be written.

Let me know what you think :)

https://accounts.shopify.com/select?rid=0db02f2b-c73c-4856-afc5-1bb8430bd498&sid=139d1b86-5ff6-4d13-b574-6471dadd903b

packages/modules/adbd

update the api to fetch user datas submissions , comments , karmas etc

A question, not a bug. Is there any way to find stories by title? Say,

hn.get_stories(title='some title%)

# or

reg_exp = re.compile('something')
hn.get_stories(title=reg_exp)

When we call the get_comments method, if story doesn't have any comments the api breaks as i keeps looking for table of comments in the page and won't be able to find it and breaks.

from hn import Story
story = Story.fromid(7324236)
comments = story.get_comments()
print comments[0].body
print comments[0].body_html

Seems like .body_html only returns a portion of the comment body's HTML.

At first glance doesn't seem to parse votes for polls.

table = soup.findChildren('table')[3] # the table holding all comments
IndexError: list index out of range

Pagination on HN is a little tricky.

Pages are in the format: https://news.ycombinator.com/x?fnid=6ZNSo6ZztcTOk5nXmNIDa6

I think 6ZNSo6ZztcTOk5nXmNIDa6 refers to a session ID or something along those lines, and it has a timeout.

https://news.ycombinator.com/item?id=3623268

See bellow output:

~ » pip install HackerNews                                                                                                                                                                 danclaudiupop@wayland
Downloading/unpacking HackerNews
  Downloading HackerNews-1.1.0.zip
  Running setup.py egg_info for package HackerNews

Installing collected packages: HackerNews
  Running setup.py install for HackerNews
      File "/home/danclaudiupop/projects/.virtualenvs/caca/lib/python2.7/site-packages/hn/hn.py", line 79
        <<<<<<< HEAD
         ^
    SyntaxError: invalid syntax


Successfully installed HackerNews
Cleaning up...

Can you also PEPify the code ? Remove whitespaces, limit all lines to a maximum of 79 characters, etc.

Thanks,

https://www.wordfence.com/products/wordfence-central/liscene

https://news.ycombinator.com/robots.txt

User-Agent: *
Disallow: /x?
Disallow: /vote?
Disallow: /reply?
Disallow: /submitted?
Disallow: /submitlink?
Disallow: /threads?
Crawl-delay: 30

Need to respect this, codebase will go into a lot of changes.

The Story class seems somewhat redundant. You could possibly use collections.namedtuple as a container for properties or simply a dictionary. The print_story method could just be the str special method.

This would mean user should be table to import Story and do something like com = Story(item_id=xxxxxxx).get_comments()

Hi again.

def get_stories(self, story_type='', limit=30):
    """
    Yields a list of stories from the passed page
    of HN.
    'story_type' can be:
    \t'' = top stories (homepage) (default)
    \t'newest' = most recent stories
    \t'best' = best stories

    'limit' is the number of stories required. Defaults to 30
    """
    if limit == None or limit < 30:
        limit = 30 # we need at least 30 items

why do you set limit back to 30?

For some weird reason, the API is throwing a weird UnicodeEncodingError.

Modify __str__ of Story to return self.title only.

Then, try this code:

from hn import HN

hn = HN()
for story in hn.get_stories():
    print story.title
    print story

The output is this:

Turn O(n^2) reverse into O(n)
Turn O(n^2) reverse into O(n)
My run-in with unauthorised Litecoin mining on AWS
My run-in with unauthorised Litecoin mining on AWS
Amazon takes away access to purchased Christmas movie during Christmas
Traceback (most recent call last):
  File "my_test_bot.py", line 11, in <module>
    print story
UnicodeEncodeError: 'ascii' codec can't encode character u'\xa0' in position 60: ordinal not in range(128)

I have no idea why this is happening, and I created a SO for this too.

I have downloaded the page that is causing this error right now for offline debugging.

Let's use HTTPS/SSL whenever we can, please set BASE_URL = 'https://news.ycombinator.com'. This, in turn, will set comments link and the link to submitter profile to HTTPS as well.

Hi, I'm having this issue:

On story Snapchat Phone Number Database Leaked, id 6993968

Traceback (most recent call last):
File "hello.py", line 9, in
for comment in story.get_comments():
File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/hn/hn.py", line 252, in get_comments
return self._build_comments(soup)
File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/hn/hn.py", line 218, in _build_comments
level = int(row.findChildren('td')[1].find('img').get('width')) // 40
IndexError: list index out of range

any idea?

Issue Type

[x] Bug (Typo)

Steps to Replicate

1. Examine hn/hn.py.
2. Search for explititly.

Expected Behaviour

1. Should read explicitly.

Semi-automated issue generated by
https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

To avoid wasting CI processing resources a branch with the fix has been
prepared but a pull request has not yet been created. A pull request fixing
the issue can be prepared from the link below, feel free to create it or
request @timgates42 create the PR. Alternatively if the fix is undesired please
close the issue with a small comment about the reasoning.

https://github.com/timgates42/HackerNewsAPI/pull/new/bugfix_typo_explicitly

Thanks.

I write some line to get top or newest stories, when i print and get error like this:

./hackernews_api.py
/usr/lib64/python2.7/site-packages/bs4/init.py:181: UserWarning: No parser was explicitly specified, so I'm using the best available HTML parser for this system ("html.parser"). This usually isn't a problem, but if you run this code on another system, or in a different virtual environment, it may use a different parser and behave differently.

The code that caused this warning is on line 12 of the file ./hackernews_api.py. To get rid of this warning, change code that looks like this:

BeautifulSoup(YOUR_MARKUP})

to this:

BeautifulSoup(YOUR_MARKUP, "html.parser")

markup_type=markup_type))
Traceback (most recent call last):
File "./hackernews_api.py", line 12, in
for story in top_iter:
File "/usr/lib/python2.7/site-packages/hn/hn.py", line 145, in get_stories
stories = self._build_story(all_rows) # get a list of stories on current page
File "/usr/lib/python2.7/site-packages/hn/hn.py", line 71, in _build_story
domain = info_cells[2].find('span').string[2:-2] # slice " (abc.com) "
TypeError: 'NoneType' object has no attribute 'getitem'

Something i went wrong, pls fix.
Thanks

Hi,

While you get and try to print the story.title in my_test_bot.py. It gives following error.
'ascii' codec can't encode character u'\u2013' in position 9: ordinal not in range(128)

Solution seems to be :
http://stackoverflow.com/questions/19232385/ascii-codec-cant-encode-character-u-u2013-in-position-9-ordinal-not-in-ran

I will send a pull request in a while.

So I added some code to mock the tests. The idea is, when testing, serve pre-downloaded html files instead of querying HN again and again. This is not working though. Anyone wants to have a look at it?

• it would be more "Pythonic" to return a str object, which was formatted using str.format.
• Use Requests (http://docs.python-requests.org/en/latest/)

https://github.com/TheAlgorithms/Python/blob/refs%2Fheads%2Fmaster/DIRECTORY.md

could do this. not sure.

Getting the following error:

AttributeError: 'NoneType' object has no attribute 'groups'