Data being reverted to a previous save when shutting down servers about roblox HOT 9 CLOSED

Can you try this and see what happens (best if it works on a slightly modified baseplate):

• Join server
• Change data in some way so that it actually saves
• Shut down all servers
• Quickly join back
• Observe your data is the old data
• Do NOT change your data
• Leave, it won't save if data isn't changed
• Join back later

What data do you get? Old data or the data from when you shut down? My theory is it's still saving by the time people rejoin.

from roblox.

I followed the steps and got the old data.

from roblox.

@Intrance1 That's strange--and it says in the console it didn't save because of unchanged data, correct? DataStore2 runs code on BindToClose, so there could be something incorrect there.

from roblox.

There's nothing in the log after the game is shutdown. I'm not sure if messages continue to be posted to the console after the server is shutdown. The message could be posted after I'm kicked from the server and that could be why I don't see anything in the console.

from roblox.

Can you see what happens when you add this somewhere in your code:

game:BindToClose(function()
    dataStore:Save()
end)

I wonder if it's a BindToClose problem or a DataStore2 problem.

from roblox.

That worked. I shutdown the server and "saved key" outputted in the console, then rejoined and had the correct data.

from roblox.

Strange, that means it must be an issue with how DataStore2 specifically implements it. Not so coincidentally, there's also no unit tests for it.

Here's the relevant lines:

It's a bit weird, but the gist of it is:

• When the player leaves (ancestry changed and they're no longer in the data model), set a "fired" flag to true after it has been saved and fire an event.
• On BindToClose, if the player hasn't successfully saved yet (the "fired" flag), wait for them to save.

This logic makes sense to me, so I'm not sure why it isn't working. While we could just call :Save() twice, this would fire two requests to save the data, which would add additional overhead.

from roblox.

So I was doing some testing with the playerLeavingConnection and I think the problem is with the AncestryChanged event. I replaced it with a PlayerRemoving event and that worked.

from roblox.

That must be it, the AncestryChanged patch is recent: 620688e

Thanks for you research! I'll fix it when I can unless you want to make a stab at a PR (that also fixes the memory leak the previous version had).

from roblox.