kakwok / levelonehcalfm Goto Github PK

CfgCVSBasePath should be fixed similarly to RunInfoPublish and used in the FM instead of the hardcoded value in the code.

Sometimes we publish RunInfo with sessionId==0. I think this can happen when there is a problem in the run. To be checked and fixed if necessary. Also, this part of the code should be cleaned, as there is code duplication here, and it looks like the logSessionConnector may be closed multiple times when it should only be closed once.

FunctionManagers now have a goToError function which can take either an error message, or an errormessage and an exception.
Replace all the copy/paste blocks with calls to this function.

UserXML should be parsed once, by the Level-1, and used to fill parameters in the Level-1 FM parameter set. Then the parameters are passed to the Level-2's, which fill their own parameter sets. The parameter values are queried and used where needed.

Right now, if an error occurs during initialize, it can cause an error state to occur. However, the function managers (including level-1) appear to go to Halted anyway, even though the transition is not marked as complete. Eventually, the transition to halted times out, since it's not marked as complete, and the state does go to error. But it should go to error right away, and not to halted first.

RunInfoPublish should only have to be specified in the Level-1 UserXML (mastersnippet) and passed to the Level-2's as a parameter (like others).

FM version: HCLAFM_globalize_v1-0-2.jar

1.1 Local run: Get to configured, but cannot take run, probably due to uHTR problem.
ERROR Unknown exception during monitoring of AMC13 in crate 30
1.2 MiniDAQ: Get to configured, but has the following errors:

2016-04-02 01:27:54 and 808 ms : cms.hcalpro.rcms.statemachine.StateMachineEngine
ERROR Transition for input SetConfigured and State Configured not defined
2016-04-02 01:27:54 and 809 ms : cms.hcalpro.rcms.fm.fw.EventProcessor
ERROR State Machine error for Input SetConfigured
2016-04-02 01:27:54 and 809 ms : cms.hcalpro.rcms.fm.fw.FunctionManager
ERROR Function Manager executeEvent: event processing failure