kaczmarj / car-safety-shiny Goto Github PK

some cars do not have the information required for this app. if a user selects one of those cars, we should show a message indicating that the data doesn't exist.

rshiny has a validate function which might be useful.

I believe the docker file would be slightly more efficient if the RUN line was before the COPY line.

The copy line will result in a different layer hash each time code is changed & copied into docker, which will invalidate the cache for all the subsequent commands.
This would mean the
RUN install2.r curl jsonlite && rm -rf /tmp/downloaded_packages line would be re-run every time code is changed.

If the lines are re-ordered (below) then the install line would be cached between builds & thus speed up image building slightly.

FROM rocker/shiny:4.1.2
RUN install2.r curl jsonlite \
    && rm -rf /tmp/downloaded_packages
COPY . /srv/shiny-server
USER shiny

if i select a volkswagen golf gti, then the image appears. but if i then select a car that doesn't have an image, the golf stays on the screen. how do we fix this?

we might run into errors with the api. it might rate limit us or not return data once in a while, and in those cases, we should alert the user that we're having problems accessing the api.

related to this, we might make an erroneous api request, that would lead to a 404. how should we handle these things? try/catch?

at the moment, i'm mostly using observe to update things like the selection choices and the car information. but how should this actually be done? what's the best way?