jzaki / bls-wallet-signer Goto Github PK

Related: jzaki/bls-wallet-extension#12

HubbleProject takes responsibility for a single initialisation of mcl (thus wasm-mcl) with its BLSSignerFactory singleton.
bls-wallet-signer bypasses this and creates BLSSigners directly and assumes repeated calls to the wasm-mcl init function will always be okay, (code-smell: "inapprorpiate intimacy").
To maintain separation of concerns, use of mcl/wasm-mcl should remain contained within HubbleProject unless really needed.

Related: "Object Orgy" regarding private key access in BLSWallet, mentioned here

Create an independent module to sign smart contract function data.

Reqs:

• have the least number of dependencies as practicable. (consideration for components of ethers)
• be a deno and/or npm module
• written in typescript
• readily usable in a browser (eg plugin)

Possible implementation here

Params:

export type FullTxData = {
  blsSigner: BlsSignerInterface,
  chainId: number,
  nonce: number, // <-- BigNumber?
  reward: BigNumber,
  contract: Contract,
  functionName: string,
  params: any[]
}

BLSSignerFactor part of hubble-bls module.

Usage example, here.