jweyrich / static-deployer Goto Github PK

The create command (e.g.: static-deployer create ... ) should:

1. Create the specified bucket (always private) if it doesn't exist;
2. Create the CloudFront distribution if it doesn't exist;
   2.1. May need to support an SPA (single page application) flag;
   2.2. May need to support custom error responses for SPA - to redirect 404 to /index.html for example;
   2.3. Enable OAI to access a private S3 bucket;
3. Create or associate domain and alternate domains;
4. Create or associate SSL certificates from ACM (needs to issue them in the NV region due to AWS limitations);

For instance, if the function update_distribution was unable to find the informed origin, it returns False and terminates immediately. It doesn't print any error message to inform the cause. See:

The function that invokes update_distribution also doesn't print any error message in case of failure. See:

We should at least print an error message to let the user know the failure cause.

We currently have a limitation related to argparser's subparsers, which I'm still not sure how to properly fix.
If you specify a config file in the command, then the command argument MUST come after the config file argument. Example:

static-deployer -c config.toml deploy --version VERSION

We currently can't use the -c <file> argument after the command (subparser), example:

static-deployer deploy -c config.toml --version VERSION

With that in mind, Click looks like a powerful and elegant alternative to argparse.

Define interfaces for implementations that support the dry-run flag so we can mock those implementations and no longer require the dry-run flag to be passed around. A dummy example to explain:

if dry_run:
  cdn_impl = MockCdnImpl()
  storage_impl = MockStorageImpl()
else:
  cdn_impl = ReadCdnImpl()
  storage_impl = RealStorageImpl()
  
cdn_impl.do_something()
storage_impl.do_something()