jveski / puppet-fileshare Goto Github PK

This is an issue with the Win32OLE object rather than with the fileshare module, but it would be very useful if a validation error could be raised for this instead of the ambiguous windows error that appears.

What happens:
When the fileshare is created and the path attribute has a trailing slash the wmi.create method returns an error code of 9, which is then translated into "invalid name". When the trailing slash is removed the share is created successfully. I believe this is occuring in fileshare.rb on liline 14 in the create method.

Here's the puppet error:
"Error: Could not set 'present' on ensure: invalid name"

The windows error code makes no sense in this case because there is nothing wrong with the name parameter. It would be nice to validate that the path doesn't end in a trailing slash or just remove it automatically in the fileshare type definition? I'm not sure the best approach as I've only run this on a single server.

OS: Windows Server 2012 R2 Standard.

C:/test will not work, c:/test will.

I should be able to say C: or c: and be able to use forward or backward slashes when specifying the path for the fileshare type.

Thanks!