justintzuriel / pe Goto Github PK

Issue description
The add-student command allows multiple parameters of the same type, but only the last specified value of that type is taken.

Steps to reproduce:

1. Use add-student with duplicate parameters e.g. duplicate NUSNET IDs add-student n/JohnTan u/johntan98 e/[email protected] i/e0892345 i/e0823445 t/tardy

Expected result:
The command should not execute.

Actual result:
The student is added and the last NUSNET ID is used.

Before execution:

After execution:

Issue description
Using the goto command on multiple sessions works, and is unexpected behavior unspecified in the UG. The goto command switches to the last session provided. The first session doesn't even need to exist inside the application. This behavior should not be allowed.

Steps to reproduce:

1. Add a session add-session s/S2 dt/23-10-2020 0900
2. Use goto e.g. goto s/S3 s/S2

Expected result:
Command should not work.

Actual result:
Application goes to last session provided.

Additional details / screenshot:

Before execution:

After execution:

Issue description
The add-session command allows multiple session names, even names of sessions already existing, which is unexpected behavior unspecified in the UG. This behavior should not be allowed.

Steps to reproduce:

1. Create a session with multiple names (even names of sessions already existing before the new session name) add-session s/S1 s/S122 dt/23-10-2020 0900

Expected result:
Command should not execute.

Actual result:
The session is added with the last name specified

Additional details / screenshot:

Before execution:

After execution:

Issue description
The implements lines of the Storage class diagram seem disconnected rather than dotted (perhaps a longer line would fix the visual problem).

Additional details / screenshot:

Closer shot:

Issue description
There are multiple returns in markStudentAttendance(). Exception is shown as return line, but activation bar is still active after the return.

Additional details / screenshot:

Issue description
The sequence diagram provided shows the execution flow of delete 1, but there is no delete command in the guides.

Additional details / screenshot:

Issue description
The score command allows multiple scores, even invalid ones, which is unexpected behavior unspecified in the UG. This behavior should not be allowed.

Steps to reproduce:

1. Create a session add-session s/S2 dt/23-10-2020 0900
2. Score a student with multiple values (including invalid values) score 2 cp/lazy cp/10

Expected result:
Command should not execute.

Actual result:
The student is scored with the last score specified.

Additional details / screenshot:

Before execution:

After execution:

Issue description
Return type of methods should be written after the method name and parameter types should be written after the corresponding parameter name.

Additional details / screenshot:

Correct notation (according to textbook):

Issue description
The mark command allows multiple attendance types, even invalid types, which is unexpected behavior unspecified in the UG. This behavior should not be allowed.

Steps to reproduce:

1. Create a session add-session s/S2 dt/23-10-2020 0900
2. Mark attendance with multiple types (including invalid type) mark 2 a/lazy a/present

Expected result:
Command should not execute.

Actual result:
The student is marked with the last attendance type specified.

Additional details / screenshot:

Before execution:

After execution:

Issue description
It seems that the arrow overlaps with the * multiplicity, making the multiplicity hard to see. One could easily miss the additional information.

Additional details / screenshot:

Issue description
The delete-session command allows multiple session names, but only deletes the last session specified.

Steps to reproduce:

1. Use delete-session with multiple session names delete-session s/S1 s/S2

Expected result:
Either all sessions are deleted or the command should not execute.

Actual result:
Only the last session specified is deleted

Before execution:

After execution:

Issue description
The application does not empty the list if lowest-score is executed where no students are present (as specified by UG).

Steps to reproduce:

1. Create a new session add-session s/CS2103 Tutorial dt/23-10-2020 0900
2. Execute lowest-score

Expected result:
According to the UG, the app will show no students if the student record list has no present students.

Actual result:
An error is thrown with the message "The student record list has no students who are present!".

Additional details / screenshot: