Giter Club home page Giter Club logo

Comments (5)

Zsailer avatar Zsailer commented on May 26, 2024 1

This might indicate that those APIs should be made into server extensions and remain separate from the server. The server only comes with the pieces in the services submodule.

from jupyter_server.

minrk avatar minrk commented on May 26, 2024

Most should probably go away. 404/error rely on page.html for the basic layout. This is really part of the notebook application, though, not necessarily shared by everything.

An argument could be made that the pure server doesn't have pages, even errors, and those are provided by extensions, and the default server should have only super-minimal error pages by default.

from jupyter_server.

Zsailer avatar Zsailer commented on May 26, 2024

We removed most of the templates in #54. We've included a minimal error page and main landing page for the server.

The main question I have is, what do we do with templates+handlers for terminals, nbconvert, editor, etc.? The notebook client includes templates, js, and css for these APIs, but the server includes the backend APIs. Should we always require that extensions provide their own frontend to these APIs?

from jupyter_server.

vidartf avatar vidartf commented on May 26, 2024

I see that the login/logout templates were removed, but the corresponding handlers are still a part of the server. What is the intended way of operation here? The auth logic should ideally be shared between different Jupyter apps on the same system, so I would argue for keeping some sane minimum implementation. Alternatively, I would prefer to keep at least an extensible template base.

from jupyter_server.

Zsailer avatar Zsailer commented on May 26, 2024

@vidartf, I agree. I actually opened an #85 to discuss this. Closing this issue in favor of #85 to focus discussion on login/logout.

from jupyter_server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.