not in git repo error ? about gv.vim HOT 10 CLOSED

FugitiveGitDir() handles all of that. You can just do

function! s:git_dir() abort
  return FugitiveGitDir()
endfunction

from gv.vim.

Thanks, tpope.

@mckellyln

You created the issue, so feel free to create a PR that removes s:git_dir() entirely and replaces its single use by FugitiveGitDir(). :)

from gv.vim.

Perhaps it is because I often invoke GV from an empty buffer and there was a change in fugitive:

@@ -181,6 +181,8 @@ function! FugitiveExtractGitDir(path) abort
   let path = s:Slash(a:path)
   if path =~# '^fugitive:'
     return matchstr(path, '\C^fugitive:\%(//\)\=\zs.\{-\}\ze\%(//\|::\|$\)')
+  elseif empty(path)
+    return ''
   elseif isdirectory(path)
     let path = fnamemodify(path, ':p:s?/$??')

from gv.vim.

Something like this works, but I'm sure there is a better way:

function! s:git_dir()
  if empty(get(b:, 'git_dir', ''))
    let l:gdir = fugitive#extract_git_dir(expand('%:p'))
    if empty(l:gdir)
      let l:gpath = './.git'
      if isdirectory(l:gpath)
        return l:gpath
      endif
    endif
    return l:gdir
  endif
  return b:git_dir
endfunction

from gv.vim.

@mckellyln

There will be two issues though:

1. It only works if you're in the root of the repo.
2. It will show . instead of the repo name in the statusline.

But the general approach is correct. So, maybe...

function! s:git_dir()
  if !empty(get(b:, 'git_dir', ''))
    return b:git_dir
  endif

  let git_dir = finddir('.git', expand('%').';')
  if !empty(git_dir)
    let b:git_dir = fnamemodify(git_dir, ':p:s?/$??')
    return b:git_dir
  endif

  return ''
endfunction

Other parts of the code use b:git_dir, so I just set it directly here. Might not be needed, though.

from gv.vim.

@mhinz awesome, thanks. Should you or I create a PR for this ?
I might still use fugitive#extract_git_dir(expand('%:p')), and only if that is empty then do your finddir code above ?

from gv.vim.

FugitiveGitDir() works in empty buffers now. For all intents and purposes fugitive#extract_git_dir() is deprecated.

from gv.vim.

ok, thank you @tpope.
So I can just do:

function! s:git_dir()
  if !empty(get(b:, 'git_dir', ''))
    return b:git_dir
  endif
  let b:git_dir = FugitiveGitDir()
  return b:git_dir
endfunction

from gv.vim.

cool

from gv.vim.

PR #70 created.
Thank you everyone.

from gv.vim.