Giter Club home page Giter Club logo

Comments (9)

odow avatar odow commented on June 11, 2024 1

Would adding the !important to the citations.css of the dev version also result in fixing the upcoming versions?

#3706 edits master. That'll fix the dev docs and all future versions. It won't fix already published versions.

from jump.jl.

odow avatar odow commented on June 11, 2024

cc @goerz have you noticed this before?

Link: https://jump.dev/JuMP.jl/stable/background/bibliography/

from jump.jl.

goerz avatar goerz commented on June 11, 2024

I have not noticed this before (maybe because I don’t use dark mode), but seems like a CSS problem. I’ll have a look

from jump.jl.

goerz avatar goerz commented on June 11, 2024

I'm also seeing this in https://juliadocs.org/DocumenterCitations.jl/stable/gallery/#author_year_style

So it's not specific to any kind of JuMP settings, but something that should be fixed in the "recommended" CSS. The bullet point is just supposed to be invisible, but it seems to clash with something in the dark mode CSS.

from jump.jl.

goerz avatar goerz commented on June 11, 2024

Yeah, documenter-dark.css is overriding the list-style: none in citations.css with list-style: disc outside.

CleanShot 2024-03-08 at 12 23 34@2x

I guess it's because the documenter-dark.css gets loaded later? Maybe we have to mark the citatations.css settings as "important".

from jump.jl.

goerz avatar goerz commented on June 11, 2024

Adding important to the citations.css seems to do the trick:

.citation ul {
 padding: 0 0 2.25em 0;
 margin: 0;
 list-style: none !important;}

I'll make a DocumenterCitations release with a new recommendation for the CSS, but you'll have to change the citations.css file manually in your existing documentation (probably directly on the gh-pages branch).

from jump.jl.

goerz avatar goerz commented on June 11, 2024

This is "fixed" in the DocumenterCitations release v1.3.3 I just made. Although updating DocumenterCitations won't really do anything for you: you'll have to modify https://github.com/jump-dev/JuMP.jl/blob/master/docs/src/assets/citations.css (and also the citations.css in existing deployed versions of your documentation)

from jump.jl.

shayandavoodii avatar shayandavoodii commented on June 11, 2024

Would adding the !important to the citations.css of the dev version also result in fixing the upcoming versions? I want to ensure that no other .css modification is required for future releases, and the change will automatically be applied to the upcoming releases.

from jump.jl.

shayandavoodii avatar shayandavoodii commented on June 11, 2024

Would adding the !important to the citations.css of the dev version also result in fixing the upcoming versions?

#3706 edits master. That'll fix the dev docs and all future versions. It won't fix already published versions.

Thank you so much. I got it.

from jump.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.