Giter Club home page Giter Club logo

Comments (4)

odow avatar odow commented on June 12, 2024 1

I don't know about this specific case. We'd have to intercept the method (::Colon)(::Int64, ::VariableRef). The issue is 1:a, regardless of the fact it appears in an @variable macro. But if we intercepted the method, we wouldn't be able give a good error message for the macro. We also can't tell, syntactically looking at @variable(model, b[1:a], Int) that a is a variable.

What we should do is improve the general case in which an error is thrown during parsing of the macro, because it is currently:

julia> @variable(model, b[1:a])
ERROR: MethodError: no method matching (::Colon)(::Int64, ::VariableRef)

Closest candidates are:
  (::Colon)(::T, ::Any, ::T) where T<:Real
   @ Base range.jl:50
  (::Colon)(::A, ::Any, ::C) where {A<:Real, C<:Real}
   @ Base range.jl:10
  (::Colon)(::T, ::Any, ::T) where T
   @ Base range.jl:49
  ...

Stacktrace:
 [1] macro expansion
   @ ~/.julia/dev/JuMP/src/macros.jl:375 [inlined]
 [2] top-level scope
   @ REPL[4]:1

from jump.jl.

LebedevRI avatar LebedevRI commented on June 12, 2024

Same with

using JuMP, SCIP

model = Model(SCIP.Optimizer)

max_a = 10

@variable(model, a, Int)

@variable(model, b[1:max_a], Int) 
@constraint(model, [i=1:a], b[i] > 0)
# Should have been @constraint(model, [i=1:max_a], b[i] > 0)

from jump.jl.

LebedevRI avatar LebedevRI commented on June 12, 2024

What we should do is improve the general case in which an error is thrown during parsing of the macro, because it is currently:

Here's another example, not sure if should go into another issue:

using JuMP, SCIP

model = Model(SCIP.Optimizer)

max_a = 10

@variable(model, a, Int)

@variable(model, b[1:max_a,1:max_a,], Int) 
@variable(model, c[1:max_a,1:max_a,], Bin) 

@constraint(model, [i=1:max_a, k=1:max_a], b[i,k] == 0
   
@constraint(model, [i=1:max_a, j=1:max_a], b[i,j] == c[i,j] * b[i,k])
# Should be  @constraint(model, [i=1:max_a, j=1:max_a], b[i,j] == c[i,j] * b[i,j])
ParseError:
# Error @ �]8;;file:///home/lebedevri/In[17]#14:1�\In[17]:14:1�]8;;�\
   
@constraint(model, [i=1:max_a, j=1:max_a], b[i,j] == c[i,j] * b[i,k])
└──────────────────────────────────────┘ ── Expected `)`

Stacktrace:
 [1] top-level scope
   @ In[17]:14

from jump.jl.

odow avatar odow commented on June 12, 2024

The parse error is because of @constraint(model, [i=1:max_a, k=1:max_a], b[i,k] == 0. You're missing a ).

As a comment, none of these are JuMP related. They're all just plain bugs in your code.

from jump.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.