julyee / jukebox Goto Github PK

• Apple music login
• Jukebox ID login
• Donate - paypal
• Sponsor - patreon

The current implementation of rating returns a string that could be "explicit", that is too close to Apples implementation and may not be compatible with other services.

Change to isExplicit which returns a boolean for future compatibility.

Only safari clients can connect (see #26) and even though they connect and the speaker icon is displayed in the client, no audio is played through the speakers.

The button and space for the camera appears but it won't ask for permission or display it.

When there are no search results the UI displays "Search Results for..." when it should display "No search results for..."

Search for: "give me tha power"

Although the host hash code is displayed when a client connects, the QR code is missing.

Due to the use of single providers, the server should implement some cacheing mechanism for lyrics.

Evaluate if implementing STUN would be necessary, although most of the features are meant to be used within the same network, there are cases where expecting all clients to be connected to a "friendly" would be unrealistic.

At the moment only one provider is being used out of about 6 available.

Implement the navigation drawer:

• Appears from the left
• Triggers a navigation event

Contains:

• Jukebox Id
• Home
• Library
• Search
• Import
• Now Playing

• Create playlist media item class
• Create playlist route
• Use album view as base.

Although the API supports videos as media items, playback is not supported.

• Hide video results from search page
• Report to Apple/make feature request
• Use youtube videos as alternative source

Should feature:

• Large artwork
• Album name
• Artist
• Release date
• Commentary (if available)
• Total duration
• Song list
• More dialog button

• Progress bar
• Scrub through progress bar
• Play/pause button
• Next button
• Previous button (needs a custom queue)
• Album art
• Song's name/artist/album name
• Song's length/current time

Currently, Jukebox QR codes can be read from external apps (i.e. the camera app) but within the app you must type the code manually. Add option to use the camera to read a QR code.

I looked at this:
https://github.com/nimiq/qr-scanner

Create a persistent player UI at the bottom of the screen:

• Album art on the left
• Song title + artist in the middle
• Progress bar at the top
• Volume pop-up on the left
• Album information controls + options on the far right

Implement a method to get a list of the upcoming songs from jukebox clients. The obvious solution would be polling but it feels like spaghetti code :(

• Hook up events for opening the album view
• Open a new page or modal view (TBD)

TBD

Create a basic UI toolbar:

• Title of section in the middle
• Menu access on the left
• Search bar on the right
• Menu items should navigate to the proper page
• Using the search bar should navigate to the search results

This happens because the recommendation service (last.fm) is not aware of the users played/queued songs.

Duplicated songs must be removed manually to adhere to the terms of service of the music providers.

When the app is started in a safari browsers, firefox and chrome fail to connect.

• Chrome returns an error
• Firefox hangs trying to connect.

• Should be designed to support

• Apple Music

• Jukebox service

• Other music services in the future

• Jukebox will not implement

• Playlist creation

• Playlist import

• Add song to library/playlist

When WebRTC fails to connect due to unreachability between clients, the connection screen just hangs

• Implement search suggestions
• Trigger search when valid string provided
• Display song results
• Display album results
• Display artist results

The current provider has a delay field in the result that is not being used, maybe that's the problem

• When a song is clicked it should immediately start playing
• The queue should be cleared
• Implement option for "play next"
• Implement option for "plat later" (play last)
• Implement option for "play now and keep queue" (?)

• Integrate Apple Music login button
• Create interface to check connection (login) before every API call

Maybe implement them karaoke style. This library can be used to fetch lyrics with some timestamps:
https://github.com/ddddxxx/LyricsProvider

If the server gets disconnected, although it reconnects automatically, the QR code is not updated.
The actual code is displayed properly though.

Implement the content area:

• Should display a new component for every navigation event
• Should occupy the largest area of the screen
• Should be "sandwiched" between the tool bar and the player