Giter Club home page Giter Club logo

Comments (8)

cortner avatar cortner commented on August 17, 2024

Q1: store positions, momenta as fields, or in a dictionary Dict{Any, Vector{JVecF}} for storing only arrays of 3-vectors, so they can be extracted without type instability.

Which other arrays need to be stored?

  • masses
  • atomic numbers
  • species symbols

from julip.jl.

cortner avatar cortner commented on August 17, 2024

Storing the cell as a matrix creates ambiguities. Are the columns or the rows the cell vectors? I would like to switch storing the cell as a list of vectors,

# either 
Tuple{JVec, JVec, JVec}
# or 
Vector{JVec}

Any concerns?

from julip.jl.

cortner avatar cortner commented on August 17, 2024

I won't do this, to keep compatibility with ASE. But instead introduced cell_vecs to get the vectors instead of the matrix.

from julip.jl.

gabor1 avatar gabor1 commented on August 17, 2024

from julip.jl.

jameskermode avatar jameskermode commented on August 17, 2024

Normally I would agree, but the function that goes from matrix to vector is already called vecs()

from julip.jl.

cortner avatar cortner commented on August 17, 2024

Normally I would agree, but the function that goes from matrix to vector is already called vecs()

that was the reason, but I'll think about it.

from julip.jl.

gabor1 avatar gabor1 commented on August 17, 2024

from julip.jl.

cortner avatar cortner commented on August 17, 2024

from julip.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.