julesguesnon / nom-span Goto Github PK
View Code? Open in Web Editor NEW๐ฆ Wrap your nom input into a span to get line, column and byte offset
Home Page: https://crates.io/crates/nom-span
License: MIT License
๐ฆ Wrap your nom input into a span to get line, column and byte offset
Home Page: https://crates.io/crates/nom-span
License: MIT License
First, thank you for creating this crate. Looks like it will be useful for a project I'm experimenting with (AsciiDoc parsing), so I'm excited to put it to work.
I want to suggest a small design shift in your Span::new
function which I think will help readability at the call sites: When I'm reading the call site, I have no idea what true
or false
means without looking at the Span
documentation.
I can think of two alternatives:
Span::new
into two new functions Span::new_for_utf8
and Span::new_for_ascii
(naming help welcome)bool
parameter with a enum Encoding
which has Utf8
and Ascii
variants.Hope this helps!
(P.S. My thinking roughly aligns with this article from Alex Kondov.)
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.