Giter Club home page Giter Club logo

nom-span's Introduction

โœจ Welcome to my universe โœจ

Profile stats

Top languages

nom-span's People

Contributors

julesguesnon avatar

Stargazers

 avatar

Watchers

 avatar  avatar

nom-span's Issues

API design suggestion: Avoid `bool` parameter to `Span::new`

First, thank you for creating this crate. Looks like it will be useful for a project I'm experimenting with (AsciiDoc parsing), so I'm excited to put it to work.

I want to suggest a small design shift in your Span::new function which I think will help readability at the call sites: When I'm reading the call site, I have no idea what true or false means without looking at the Span documentation.

I can think of two alternatives:

  1. Split Span::new into two new functions Span::new_for_utf8 and Span::new_for_ascii (naming help welcome)
  2. Replace the bool parameter with a enum Encoding which has Utf8 and Ascii variants.

Hope this helps!

(P.S. My thinking roughly aligns with this article from Alex Kondov.)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.