jules / grumpkin Goto Github PK

View Code? Open in Web Editor NEW

28.0 28.0 4.0 53 KB

Implementation of the Grumpkin curve in Rust.

License: Apache License 2.0

Rust 100.00%

grumpkin's People

Contributors

Stargazers

Watchers

Forkers

tomafrench leonardoalt huitseeker zhenfeizhang

grumpkin's Issues

Derive endomorphism constants to enable GLV mul

sqrt check?

I noticed today that this repo changes the halo2curves sqrt test for BN256 from

CtOption::new(tmp, tmp.square().ct_eq(self))

CtOption::new(tmp, !self.ct_eq(&Self::zero()))

in https://github.com/jules/grumpkin/blob/main/src/fr.rs#L194.

I noticed it when it started giving me wrong square roots for Fr elements (here BN's Fq), so wondering how that works.

fresh checkout does not compile

Just tried a fresh checkout of the repo and I get the error below. This error itself happens because halo2-curves removed Group from their lib.rs.
derive.rs has an impl for group::Group and another for Group, so I inferred that this Group must be pasta_curves::arithmetic::Group. However importing that brings a whole bunch of other issues I'm unsure how to solve.

error[E0432]: unresolved import `halo2curves::Group`
  --> src/curve.rs:10:71
   |
10 | use halo2curves::{Coordinates, CurveAffine, CurveAffineExt, CurveExt, Group};
   |                                                                       ^^^^^
   |                                                                       |
   |                                                                       no `Group` in the root
   |                                                                       help: a similar name exists in the module: `group`