jsnmrs / aggro Goto Github PK

Versions after 7.0.1 get stuck in a "this release already exists" loop. This has caused me to revert from 7.0.2 in #367 and revert from 7.1.1 in #392.

❯ fin exec vendor/bin/dep deploy stage=prod -o release_name=88
task deploy:info
[bmxfeed.com] info deploying HEAD
task deploy:setup
task deploy:lock
task deploy:release
[bmxfeed.com]  Deployer\Exception\Exception  in release.php on line 108:
[bmxfeed.com]
[bmxfeed.com]   Release name "88" already exists.
[bmxfeed.com]   Release name can be overridden via:
[bmxfeed.com]   dep deploy -o release_name=89
[bmxfeed.com]
task deploy:failed
task deploy:unlock

To troubleshoot, attempt to deploy to production from the command line.

The nested query approach for fetching featured stories seems inefficient:
app/Models/NewsModels.php > public function featuredPage()

The output view for the featured page has some odd loops happening, too:
app/Views/featured.php

The featured page requires a separate process and cron to build itself, so the user-facing page always has a loaded cache.

Emojis in video titles are causing some issues. It appears that everything after an emoji is being stripped out of title.

https://bmxfeed.com/video/eOnkPH3dQU8 loses it's title altogether. Spotted this via a Lighthouse scan that returned 97 out of 100 for accessibility due to the empty link.