Giter Club home page Giter Club logo

Comments (2)

edbzn avatar edbzn commented on May 23, 2024 1

Hi @ntziolis, thank you for spotting this!

Initially we had an --initial-release flag but we removed it as we wanted to make it transparent for the user. It seems to be weak to base our assumption on what's Nx generate (0.0.1), so I would suggest to update the getCurrentVersion function with the following logic :

  • get the last semver tag
  • (first fallback) get the last tag git describe --tags --abbrev=0
  • (second fallback) get the first commit git rev-list --max-parents=0 HEAD

This would also fix users that started to release using another tool with different tag format (without tag prefix for example).

from semver.

ntziolis avatar ntziolis commented on May 23, 2024

I would suggest to update the getCurrentVersion function with the following logic :

  • get the last semver tag
  • (first fallback) get the last tag git describe --tags --abbrev=0
  • (second fallback) get the first commit git rev-list --max-parents=0 HEAD

That would be perfect as this doesn't require the user to intervene manually in majority of cases.

from semver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.