Comments (2)
Hi @ntziolis, thank you for spotting this!
Initially we had an --initial-release flag but we removed it as we wanted to make it transparent for the user. It seems to be weak to base our assumption on what's Nx generate (0.0.1), so I would suggest to update the getCurrentVersion
function with the following logic :
- get the last semver tag
- (first fallback) get the last tag
git describe --tags --abbrev=0
- (second fallback) get the first commit
git rev-list --max-parents=0 HEAD
This would also fix users that started to release using another tool with different tag format (without tag prefix for example).
from semver.
I would suggest to update the
getCurrentVersion
function with the following logic :
- get the last semver tag
- (first fallback) get the last tag
git describe --tags --abbrev=0
- (second fallback) get the first commit
git rev-list --max-parents=0 HEAD
That would be perfect as this doesn't require the user to intervene manually in majority of cases.
from semver.
Related Issues (20)
- Question: how can I trigger changes/release to app when updating dependency using `*`
- projectName is interpolated by NX now HOT 2
- Drop Angular CLI compatibility HOT 1
- targetDependencies is removed in Nx 16+ HOT 2
- Question: How to proceed if NPM publish fails HOT 1
- Custom headerPattern doesn't get picked up by changelog conventional-commit-parser HOT 1
- Preset Schema doesn't match the DOCs HOT 2
- Support pnpm in install generator (husky) HOT 2
- Drop old `${var}` interpolation syntax
- Bug: Changelog template not included in npm package HOT 2
- Publish new version for nx 17
- Version task never returns with nx 17 and version 4.0.0 HOT 4
- Does the announcement of a `nx release version` and `nx release changelog` affect the development of the plugin? HOT 2
- All projects are failing with unspecific error message HOT 5
- Drop deprecated post-targets "<project>:<target>" syntax
- nx run core-types:version --push=true --baseBranch=feature/SAD : failed Error: fatal: Unable to create '/bp2/src/.git/index.lock': File exists. HOT 1
- Could not find 'nx' module in this workspace. Error: [readCachedProjectGraph] ERROR: No cached ProjectGraph is available. HOT 2
- Question about `post-targets` and n`gx-deploy-npm:deploy` HOT 2
- Calculating wrong version number HOT 2
- Document differences with `nx release` and migration options HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from semver.