Giter Club home page Giter Club logo

Comments (2)

edbzn avatar edbzn commented on September 22, 2024 1

Hi, to avoid pushing tags and version commits if NPM publish fails you could do this:

  • set --push to false as the push occurs before post-targets
  • write a custom post-target "git-push" that pushes the new version
  • declare the "git-push" target next to the NPM publish so it's not executed if the publish fails

So it could look like:

"targets": {
  "version": {
    "executor": "@jscutlery/semver:version",
    "options": {
      "postTargets": ["npm-publish", "git-push", "github-release"]
    }
  },
  "npm-publish": {
    "executor": "ngx-deploy-npm:deploy",
    "options": {
      "access": "public"
    }
  },
  "git-push": {
    "command": "git push --atomic --follow-tags"
  },
  "github-release": {
    "executor": "@jscutlery/semver:github",
    "options": {
      "tag": "{tag}",
      "notes": "{notes}"
    }
  }
}

from semver.

carstenrntng avatar carstenrntng commented on September 22, 2024 1

Just fyi: If you try something like above, be aware that concurrent commits to your main branch will break the above workflow. This may due to concurrent runs of your release pipeline, or something pushing directly to your main branch. You may end up with a package release to npm without release commit & tag being pushed to your main branch.

I personally find it much easier to have tested & tagged commits in git and have an additional manually-run workflow that, given a tag name, (re)publishes this tag as a package to npm in case a previous publish failed.

from semver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.