jrook1445 / wannaroo-basic-industries Goto Github PK

change to 65% to match RCYC Chain in WRExInd

also need to update Industry Matrix

otherwise, WATR can only go to Shop, Superstore

only build Water Tower if neither Shop, Superstore in town

update industry matrix spreadsheet, and also add that temp/arctic farm not above snowline

industries.pnml existing code, line 207:

switch (FEAT_INDUSTRIES, SELF, prod_change_increase, production_level) {
    param_max_prod_level: return [STORE_PERM(0, 0x16), CB_RESULT_IND_PROD_NO_CHANGE];
    prod_change_increase_2;
}

changed to:

switch (FEAT_INDUSTRIES, SELF, prod_change_increase, production_level) {
    (param_max_prod_level+1)..128: return [STORE_PERM(-1, 0x16), CB_RESULT_IND_PROD_DECREMENT_BY_1];
    param_max_prod_level: return [STORE_PERM(0, 0x16), CB_RESULT_IND_PROD_NO_CHANGE];
    prod_change_increase_2;
}

unsure why original does not work?

Review location_checks.pnml - same town mutually exclude some secondary industries:

• Refinery and Steel/Paper Mill
• Refinery and Foodproc (RFPR)?
• Factory and Foodproc
• Temp/Arctic Factory and Sawmill (WDPR)

To avoid too many industries clustered around a town.

should change

(param_max_prod_level+1)..128

to

(param_max_prod_level+1)..129

It seems the recycling plant industry is missing a texture. I'm presuming it's an issue with Opengfx2, which I'm also using, but I want to report it here too just in case it's an issue. I'm using JGR Patch pack 0.56.2 with no other GRFs loaded.
With OpenGFX2

With Opengfx

perhaps similar to one used in Tourist inds:

• 1. instead manipulate the production level instead of the production rate (but min prod level 4)
• 2. only start prod changes when industry initialised (1st cargo pickup)
• 3. life type => black hole so inds don't close
• 4. add parameter for max production rate (32-128)
• 5. Document storage registers
• 6. test if STORE_PERM(1, 0) is being used in produce_256 blocks of refinery, foodproc, steel mill, paper mill; remove if not needed

line 303 in industries.pnml

STORE_PERM(check_transported_last_month_pct()>0, 0x0F)

does not take into account the case that industry has been initialised but is now ignored/abandoned

behaviour should be that production decreases, but as is, production will not change

need something to check 0x0F not already == 1 or something

Find a way to prevent industries being built right next to each other without using tile checks.

Not many industries so maybe just check industry ids one-by-one?

Maybe add basecost params as in tourist set, so we can use those without loading the tourist set?

rcyc.pnml
build.sh

fix switch rcyc_plant_monthly_prod_change

% was in range 0..255 in nml 0.5.0, but now fixed in master 2020-05-09

change code to use fixed range of 0..100

also change build.sh to use updated nml

also see issue 6 in wannaroo-extra-industries

will prob need to be in houses.nfo:
check parameter, if true then skip to end of file

add random_prod_change cb, return NO_CHANGE, to 1) depot and 2) plant in rcyc.pnml

also, add monthly_prod_change cb, return NO_CHANGE, to shop.pnml

512/month seems a lot...

have a parameter to set a lower max

bitmask(INDTILE_FLAG_ACCEPT_ALL) does not override default cargo acceptance:

1. Temp factory tiles still accept Grain, Livestock
2. Tropic factory tiles still accept Copper, Rubber

comment out bitmask(INDTILE_FLAG_ACCEPT_ALL) and replace with accepted_cargos

in produce_256 blocks of refinery, foodproc, steel mill, paper mill; remove if not needed

Commented-out for 1.1.0 release as I could not find LOAD_PERM(0 | 0x0 | 0x00) anywhere in code.

Must be a copy/paste artifact, or I started an idea that didn't finish?

Have tested commented-out with steel mill and seems ok, we'll see.

With population checks, processing inds (refinery, factory, sawmill, foodproc, etc) may not be built.

i.e. when using town sets such as Improved Town Layouts, TaI because these sets reduce town population.

So check industry count when doing population check, if count == 0 then ok to build.

Change location_checks.pnml to prevent Rcyc Depot/Rcyc Plant in same town. Town has one or the other, but not both.

• Desal Plant produces RFPR | RCYC | GRVL, so need to do some new checks

• also, removing WOOD and RFPR from Dist Center, so comment-out checks:

• Lumber Mill -> Dist Center -> Lumber Mill

• Forest -> Dist Center -> Lumber Mill