Giter Club home page Giter Club logo

kerbalengineer's People

Contributors

antplant avatar cybutek avatar deram avatar dewiniaid avatar dmagic1 avatar gerry1135 avatar harryyoung avatar itwtx avatar jacalz avatar jrbudda avatar kerbas-ad-astra avatar mic-e avatar politas avatar rcrockford avatar rkagerer avatar saybur avatar sigma88 avatar tallmyr avatar teknoman117 avatar yalov avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

kerbalengineer's Issues

About Localization

I am going to do some localization to your mod.
Just like this:
image
If you allow me to do it, I will pull request some day

Cannot resolve assembly errors, with solution

KER 1.1.7.1, in a 1.8.1 game

Getting the following errors:

ADDON BINDER: Cannot resolve assembly: KerbalEngineer.Unity, Culture=neutral, PublicKeyToken=null
 
ADDON BINDER: Cannot resolve assembly: KerbalEngineer.Unity, Culture=neutral, PublicKeyToken=null

Quick n dirty solution is to rename the KerbalEngineer.Unity.dll to +KerbalEngineer.Unity.dll

Better solution is to add the following to the AssemblyInfo.cs:
[assembly: KSPAssemblyDependency("KerbalEngineer.Unity", 1, 0)]

Missing files to compile project

I downloaded 1.1.6 source code and it's missing 4 files needed to successfully compile KER:

..\Flight\Readouts\Orbital\CurrentSoi.cs
..\Flight\Readouts\Vessel\SuicideBurnProcessor.cs
..\UIControls\DropDown.cs
..\UIControls\WindowObject.cs

RO / RP-1 / RSS: KerbalEngineer.Flight.Readouts.Body.GeostationaryHeight.Draw

This appears several times in the log:

NullReferenceException: Object reference not set to an instance of an object
  at KerbalEngineer.Flight.Readouts.Body.GeostationaryHeight.Draw (ISectionModule section) [0x00000] in <filename unknown>:0 
  at KerbalEngineer.Flight.Sections.SectionModule.DrawReadoutModules () [0x00000] in <filename unknown>:0 
  at KerbalEngineer.Flight.Sections.SectionModule.Draw () [0x00000] in <filename unknown>:0 
  at KerbalEngineer.Flight.Sections.SectionWindow.Window (Int32 windowId) [0x00000] in <filename unknown>:0 
  at UnityEngine.GUILayout+LayoutedWindow.DoWindow (Int32 windowID) [0x00000] in <filename unknown>:0 
  at UnityEngine.GUI.CallWindowDelegate (UnityEngine.WindowFunction func, Int32 id, Int32 instanceID, UnityEngine.GUISkin _skin, Int32 forceRect, Single width, Single height, UnityEngine.GUIStyle style) [0x00000] in <filename unknown>:0 
 
(Filename:  Line: -1)

full log and stuff (still in game):
https://www.dropbox.com/s/8u7kgh1sr852hqe/output_log.txt%20and%20stuff%202019-05-29-01.zip?dl=1

and btw
KER has issues to show the correct dV / TWR at all with engines that are patched by RO and got ModuleEngineConfigs

Getresource errors crashing game

I usually notice these while I'm in the VAB, but I'll notice a flicker in the texture of the header in the floating huds for KER, meanwhile my player log is spamming the following:

Resource ID out of range in GetResource: 1360342 (max is 1048575)
(Filename: ./Runtime/GfxDevice/GfxResourceIDMap.h Line: 109)
At a very high speed, if left like this the game will eventually crash. (Player log usually is 500+ mb by the time I notice)

I've been leaving a tail -f on the Player.log so I can notice when this happens.

The only addons I'm currently running is the current KER 1.1.7.1, X Science Continued 5.26, and Zero MiniAVC 1.1.0.1

[Request] Add a line break separator in the 'miscellaneous' category

Currently the only separator in the miscellaneous category is an actual graphical line, but it would be nice to have a line break.

e.g.:

Currently, two readouts can be separated like so:

Time to apoapsis hh:mm:ss
————————————
Time to periapsis hh:mm:ss

Suggested:

Time to apoapsis hh:mm:ss

Time to periapsis hh:mm:ss

KER ignores UI Scale setting

Running KSP at a high resolution with UI scale set to 150%, I find the KER text small and difficult to read. How hard would it be to make KER read the scaling from the game's configuration and use it as well?

Panels forget their "float" state

Hello!
After visiting KSC or Tracking Station all panels become non-float. Positions are preserved (after pressing "float" panel returns to it's original position), but the state is not.
Looks like appeared after v1.1.4.7 or v1.1.4.8.

A short demo video:
https://youtu.be/jIJqbL6JnWI

KER and Kopernicus and OPM

with Kopernicus and OPM I get those:

KerbalEngineer ->  // Array index is out of range.
 
(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

KerbalEngineer ->   at MapSO.GetPixelColor (Int32 x, Int32 y) [0x00000] in <filename unknown>:0 
  at CBAttributeMapSO.GetPixelColor (Double x, Double y) [0x00000] in <filename unknown>:0 
  at CBAttributeMapSO.GetAtt (Double lat, Double lon) [0x00000] in <filename unknown>:0 
  at ScienceUtil.GetExperimentBiome (.CelestialBody body, Double lat, Double lon) [0x00000] in <filename unknown>:0 
  at KerbalEngineer.Flight.Readouts.Surface.ImpactProcessor.Update () [0x00000] in <filename unknown>:0 

and some of those

KerbalEngineer ->  // Object reference not set to an instance of an object
 
(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

KerbalEngineer ->   at KerbalEngineer.Editor.BuildOverlayResources.OnGUI () [0x00000] in <filename unknown>:0 

The last session created a huge log, a lot of Kopernicus errors, I already opened a thread here: https://forum.kerbalspaceprogram.com/index.php?/topic/173537-lot-of-nre-with-kopernicuscomponents/
You also find the full log there.
Log: https://www.dropbox.com/s/bag5iqd6b3r8cx4/2018-04-06_1%20KSP.log.7z?dl=1

I have no clue where to start to find the culprit.

Request - Force Full fuel reserve

I have a request for a feature.

I'm playing with resources that can only be mined on other planets and used for fuel. This results in my new vessels does not have that fuel in editor, thus being impossible to get a reading on.
Would it be possible to force the calculation to act as if that resource was available? I'm thinking for specific resources.

I'm thinking to accept that it will be imperfect, like not trying to calculated the mass changes and stuff, but just assume enough is available. this would also help with special engines the uses Air/atm as "fuel" that affects ISP.

Right now. I'm building those in blind, or doing calculations by hand....

Mass and dV calculations with crew mass

I have modded the KerbalCrewMass value in Physics.cfg (as many have). In the latest release of KER (1.1.5.7) adding crew to a ship in the VAB sends all the KER values haywire. It worked more or less fine before.

Spurious torque

The attached craft should have zero torque. Yet, KER shows 0.01 kNm. Maybe a floating point round off error?

Image of the craft

To reproduce simply place an S4-512 Fuel Tank and attach 4 vector engines using 4 way symmetry on the bottom. Or load the craft file: https://pastebin.com/Y1mMvEbq

Note, that while 0.01 seems like an insignificant amount, this is just a minimal example. I have a larger craft where the errors add up to significant amounts.

Using name and not displayname

Hey.

Kerbal Engineer's biome readout is reporting the "name" of the biome and not the "displayname", which means any biomes that have names "Biome1, Biome2, Biome3 etc" shows up on KER, whereas it should be using the displayname.

This help for localisation in mods, specifically planet mods. Without using displayName, localisation of biome names is impossible. Would it be possible to update KER to use biome displayNames?

Cheers.

NRE KerbalEngineer.Flight.Readouts.Rendezvous.RendezvousProcessor.Update

This happens in early career, there is nothing to rendezvous with ...
I just launched a sounding rocket.

KerbalEngineer -> Exception  // System.NullReferenceException: Object reference not set to an instance of an object
  at KerbalEngineer.Flight.Readouts.Rendezvous.RendezvousProcessor.Update () [0x00000] in <filename unknown>:0 
  at KerbalEngineer.Flight.FlightEngineerCore.UpdateModules () [0x00000] in <filename unknown>:0 
 
(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

KerbalEngineer ->   at KerbalEngineer.Flight.Readouts.Rendezvous.RendezvousProcessor.Update () [0x00000] in <filename unknown>:0 
  at KerbalEngineer.Flight.FlightEngineerCore.UpdateModules () [0x00000] in <filename unknown>:0 
 
(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

Radar Altimeter

  • my PR #33 fixed landed underwater case, but spoiled case, when a kerbal or a vessel landed on an another vessel, which it splashed on the surface of the water.
  • possible adopt future ksp1.7 algorithm
  • possible adopt Basic Orbits algorithm, it determines other vessels
  • possible adopt SirDiazo's algorithm (the distance from the lowest point on a vessel to the surface):
    https://github.com/SirDiazo/LandingHeight

Contributing

I'd like to try and contribute to KER. Specifically I'm hoping to add kerbonaut mass to any command chairs when calculating dV. Before I can get that far, I'm having trouble recreating the build environment to compile a new fork of this.

I've managed to sort out some issues by making the links for game and KSP-Environment to find the dlls. Still I'm ending up with files not found that exist in CYBUTEK's repository. I overlaid both sources to catch those, added them to the project, but that made things worse.

I'm wondering if you could put together a small blurb how someone can mimic your setup: version of VS, plugins, etc; to work from the same base. kOS did a good one at https://github.com/KSP-KOS/KOS/blob/develop/CONTRIBUTING.md that you could plagir^H^H^H^H^H^H^H leverage as a starting point.

Thanks.

Typo in "gravity" readout + suggestion

The units for the "gravity" readout in the vessel preset are in m/s when it should be m/s^2.

Also, a minor gripe: perhaps rename to "gravitational acceleration", and on that note it'd be nice to have a "gravitational force" readout to compliment the acceleration.

Text Becomes Unreadable

Exception AtmosphericProcessor->CheckAeroMods

KerbalEngineer -> Exception AtmosphericProcessor->CheckAeroMods // System.NullReferenceException: Object reference not set to an instance of an object
  at KerbalEngineer.Flight.Readouts.Surface.AtmosphericProcessor.CheckAeroMods () [0x00000] in <filename unknown>:0 
 
(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

This occurs only one time lonely in a session.

Actually I'm trying to find the culprit for the random event of the maneuver delta-V bar not decreasing on a maneuver burn (but the KER readout changes accordingly).
Dunno if this has to do with it.
This happens sometimes, sometimes not, under similar circumstances.

Log:
https://www.dropbox.com/s/nv2lmoaa6arfc0x/2018-06-25_1%20KSP.log.7z?dl=1

[Request] Ability to round numerical data to a specified decimal point

Some of the data KER displays really doesn't need to be displayed to such a high degree of precision. It makes reading data on the fly more difficult and, in my opinion doesn't add much, if any benefit.

In the section editor, the 'install' and 'remove' buttons can be shrunk, the '?' doesn't really need to be in the 'installed' section, and in addition to the up and down position arrows, left and right numerical precision arrows could be added in the space gained by shrinking the 'remove' button, and removing the '?' button from the 'installed' section.

Alternatively, a global numerical precision adjustment could be added to the KER popup.

Here's a quick mockup I did showing what I mean:

https://i.imgur.com/LJ4bJk6.png

The GUI size is wrong and cannot be resized

CYBUTEK#146

Actually this issue comes form original KER branch. But It seems that original KER branch doesn't work any more, so I politely request this problem in here. If you have a little time, please look around this. This one is really serious problem for some language users.
Above issue suggest that i can solve it by changing encoding with hands. But KER overwrite xml file, so it isn't solution.
This issue is related to language encoding problem. Therefore you can't reproduce bug. If you send me file, i will gladly test it for you. please send file to calanchue at gmail.com

Thank for advance

HUD do not show during flight.

Hello,
i installed KSP as well as your latest KerbalEngineer Version yesterday.
It works fine while building vehicals, but I dont have any HUD's during flight.
(The KER-Logo is displayed on the right, but i cannot click it).
Are there any settings I need to make to enable the hud, or might that be a bug?
Regards

Wrong in 1.8

In 1.8.0.2686 bad graphics.
For example, HUD.
screenshot4
screenshot6

Min KSP Version should be updated

Hi,

I recommend to update the min KSP version of the .version file otherwise the latest release would seem to be compatible with KSP 1.6.1 but actually is not compatible due to the changes done in KSP 1.7 to some parts like the Decouplers.

Request: option to import maneuver nodes when stored vessel doesn't exist

Quite often I will set up some maneuver nodes, and add an alarm. Then I dock to a station for fueling etc. before the node. When I undock, the vessel has a new vessel ID, so it would be nice if I could import the nodes from the alarm, however currently it just displays that the stored vessel ID no longer exists.
It would be nice if there was an option to restore the nodes in such a case.

broken filters with KER 1.1.5.5 on KSP 1.6

How to reproduce

  1. Install KSP 1.6
  2. Copy KerbalEngineer (https://github.com/jrbudda/KerbalEngineer/releases/tag/1.1.5.5) to GameData
  3. Start Launcher.exe
  4. Click Play
  5. KER AVC, say No
  6. close change log
  7. Start Game
  8. Start New > Start!
  9. Acknowledge Gene, enter VAB
  10. Acknowledge Wernher
  11. top left: ||> enable advanced mode
  12. Filter by Cross-Section profile
  13. notice how cockpits are still shown, can no longer change any part selection except whatever was filtered before clicking cross-section profile.

output_log.txt

The exact same thing happens with other mods, I've reported this to RealChutes: ChrisViral/RealChute#82

I'm still narrowing down which mods cause this, so far found two.

Request: Readout for target SOI / low orbit / high orbit borders

Just to have these informations handy before planning a fine-tune target periapsis burn.

The SOI I can already get from the stock body parameters readout in the tracking station or the map view.

But not the other both, so I request at least these two readouts.

[Request] Multiple Columns

I'd like to create horizontally-spaced readouts like so:

img

It'd also be really nice to be able to resize the GUI editor windows.

window gone in VAB

I've just updated to the latest version (1.1.6.0) via ckan, and my KER window has disappeared from VAB (the main window showing all the buttons & delta-v).

Additionally, the "vessel" details got borked up, too.

I've reverted back to v1.1.5.7 and all is dandy.
Using ksp v1.6.1

VAB/action Group window

The KER window closes if I enter the action group window inside the VAB/SPH. Not really a bug but would be nice if it stays open and gets a dry mass display as well.

Useful for some other mods like RealChutes (setup for the chutes is made inside the action groups screen).

Dry mass would be useful to know how many parachutes I have to attach for reusable stages. Atm I have 2 windows open always (mechjeb shows only dry mass) but I really prefer the engineer window.

CUSTOMIZING PROBLEM

Hi.
I detected a problem with the customization of HUD. When you try to change de HUD informations, adding new data like "Time to node burn" or "Time burn", or another information, the HUD doesn't display the information different of the preset….

Greetings from Spain

API for other mods

May I propose something along these lines:

KER.API.AddSection(string sectionName, List<string> variableNames, MyValueCallback);

public string MyValueCallback(Vessel vessel, string sectionName, string variableName) {
  return "hello!";
}

That way users would be able to add values of other mods to the KER HUD, including all the bells and whistles that KER already provides. We'd use this for telemetry values like CO2 levels, as well as for science related values (sun-body-angle)

Kerbalism/Kerbalism#380

(PS: posted this in CYBUTEK#154 before. I love orphaned projects)

KER GUI Settings Not Saving

Is it just me? Not that it's a game killer, but every time I start up I have to reset my KER GUI size. It seems to be stuck at "0".
KER v1.1.7.1
KSP v1.8.1

Occurs to me I should mention I'm on iOS 10.15.1 and as I recall there is some issue some other modder had in writing saves to Unix based systems. I wish I could remember what exactly that was. That issue got resolved, but as I also recall it had something to do with the way the file tree works vs how he had specifically written for some fancy way of doing it for Windows (version unknown).

AltitudeTerrain.cs - AGL?

you have this calculation

if (FlightGlobals.ActiveVessel.terrainAltitude > 0.0
                || FlightGlobals.ActiveVessel.situation == Vessel.Situations.SPLASHED)
                return FlightGlobals.ship_altitude - FlightGlobals.ActiveVessel.terrainAltitude;
            else
                return FlightGlobals.ship_altitude;

so where I can find a not splashed place with terrainAltitude < 0 ?
if the place is exist, why in a flight above the place, it shows ASL, and not AGL?

No info for rendezvous in Tracking Center

When I open up the Tracking Center and open up KER to find an interplanetary transfer window, there is no info available. However, rendezvous info is present if I am piloting a spacecraft. I have already tried removing all other mods, but the problem seems to be in KER.

Here is a screenshot:
screenshot_2018-06-01_21-37-20

KerbalEngineer.version needs URL update

The .version file supplied with KER contains a URL 1.3 version file. One suggestion is to provide the URL to this repo.

[LOG 21:54:44.148] MiniAVC -> S:\SSD Games\Modded KSP 1.4.3\GameData\KerbalEngineer\KerbalEngineer.version
NAME: Kerbal Engineer Redux
URL: http://ksp-avc.cybutek.net/version.php?id=6
DOWNLOAD: NULL
GITHUB: NULL
VERSION: 1.1.4.10
KSP_VERSION: 1.4.2
KSP_VERSION_MIN: 1.4
KSP_VERSION_MAX: 1.4.9
CompatibleKspVersion: False
CompatibleKspVersionMin: True
CompatibleKspVersionMax: True
CompatibleGitHubVersion: True
[LOG 21:54:44.148] MiniAVC -> http://ksp-avc.cybutek.net/version.php?id=6
NAME: Kerbal Engineer Redux
URL: http://ksp-avc.cybutek.net/version.php?id=6
DOWNLOAD: http://kerbal.curseforge.com/projects/kerbal-engineer-redux
GITHUB: NULL
VERSION: 1.1.3
KSP_VERSION: 1.3
KSP_VERSION_MIN: 1.2.9
KSP_VERSION_MAX: 1.3.1

CompatibleKspVersion: False
CompatibleKspVersionMin: True
CompatibleKspVersionMax: False
CompatibleGitHubVersion: True
UpdateAvailable: False

KER and Making History Pods

KSP v1.5.1.2335
Making History v1.5.1
KER 1.1.5.4

Issue: When adding pods from the Making History expansion, KER does not account for them and thus doesn't adjust delta-v calculations or weight calculations and the like.

How to reproduce:
Fresh install of KSP from Steam, KER 1.1.5.4 from here. Load up game, load save, go to VAB. Add tank and engine, check dV calcs. Add normal command pod, see values adjust. Add round Making History pod, calcs do not adjust.

ksp_dv_nopod
ksp_dv_mk1cmdpod
ksp_dv_onionpod

Incorrect Relative Velocity value

Hello!
Looks like after v1.1.4.7 or v1.1.4.8 Relative Velocity readout from the Rendezvous section shows incorrect values. Moreother, Relative Speed readout shows the same value in any situation.

Screenshot:
kerbal engineer redux velocity bug

New career, no vessel yet, tracking station issue with KER

I get a lot of those:

KerbalEngineer -> DisplayStackTS->Window // Object reference not set to an instance of an object
 
(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

KerbalEngineer ->   at MapObject.GetName () [0x00000] in <filename unknown>:0 
  at MapObject.GetDisplayName () [0x00000] in <filename unknown>:0 
  at KerbalEngineer.Flight.Readouts.Rendezvous.RendezvousProcessor.nameForTargetable (ITargetable tgt) [0x00000] in <filename unknown>:0 
  at KerbalEngineer.TrackingStation.DisplayStackTS.Window (Int32 windowId) [0x00000] in <filename unknown>:0 
 
(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

It looks like this:
https://i.imgur.com/putBEhF.png

Log: https://www.dropbox.com/s/727cjcjfnbsf22v/2018-04-07_1%20KSP.log.7z?dl=1

Cost calculation run even during flight

This can cause a significant performance impact when the user has tons of mods. Calls to Part.GetModuleCosts means that KSP iterates over all the PartModules that the part has to find the ones that implement IPartCostModifier. To make matters worse, some mods can have quite substantial functionality inside the cost modifer code.
I would suggest not querying the part costs inside the simulations because that info is not relevant inside the flight scene anyway.
Here's the stack where KER queries the part cost:

   at Part.GetModuleCosts(Single defaultCost, ModifierStagingSituation sit)
   at KerbalEngineer.Extensions.PartExtensions.GetCostDry(.Part part)
   at KerbalEngineer.VesselSimulator.PartSim.New(.Part p, Int32 id, Double atmosphere, KerbalEngineer.LogMsg log)
   at KerbalEngineer.VesselSimulator.Simulation.PrepareSimulation(KerbalEngineer.LogMsg _log, System.Collections.Generic.List`1 parts, Double theGravity, Double theAtmosphere, Double theMach, Boolean dumpTree, Boolean vectoredThrust, Boolean fullThrust)
   at KerbalEngineer.VesselSimulator.SimManager.StartSimulation()
   at KerbalEngineer.VesselSimulator.SimManager.TryStartSimulation()
   at KerbalEngineer.Editor.BuildAdvanced.Update()

Request: recognize all RealFuels for TWR/Thrust/dV calcs

I just launched a rocket, first stage with MMH/NTO and no Thrust/TWR/dV is shown.
But the 2nd stage is already shown, with Hydrazine as fuel.

This lets me guess that not all fuel types added by RealFuels are taken into account.

I got a few of these but I'm not sure if this is because of this issue or something else:

NullReferenceException: Object reference not set to an instance of an object
  at KerbalEngineer.Flight.Readouts.Body.BodyName.Draw (ISectionModule section) [0x00000] in <filename unknown>:0 
  at KerbalEngineer.Flight.Sections.SectionModule.DrawReadoutModules () [0x00000] in <filename unknown>:0 
  at KerbalEngineer.Flight.Sections.SectionModule.Draw () [0x00000] in <filename unknown>:0 
  at KerbalEngineer.Flight.Sections.SectionWindow.Window (Int32 windowId) [0x00000] in <filename unknown>:0 
  at UnityEngine.GUILayout+LayoutedWindow.DoWindow (Int32 windowID) [0x00000] in <filename unknown>:0 
  at UnityEngine.GUI.CallWindowDelegate (UnityEngine.WindowFunction func, Int32 id, Int32 instanceID, UnityEngine.GUISkin _skin, Int32 forceRect, Single width, Single height, UnityEngine.GUIStyle style) [0x00000] in <filename unknown>:0 
 
(Filename:  Line: -1)

Log and craft:
https://www.dropbox.com/s/x0bjuqjvlgd1hns/2018-05-23_1%20KSP.log.7z?dl=1

https://i.imgur.com/mmwBXW9.png

1.1.5.3 beta test

1.1.5.3, 2018-7-27, KSP 1.4.5 #2243

  • Total overhaul of impact and suicide burn calculations.
  • Added impact marker to map and flight view. Toggleable via the Impact Marker readout button.
  • Add suicide burn countdown and burn length readouts.
  • Add minimum safe orbtial altitude readout.
  • Change a number of default sections and readouts. Will only apply to a clean install.

KerbalEngineer-1.1.5.3.zip

Hardcoding KpaToAtmospheres

Here and here you use the stock property PhysicsGlobals.KpaToAtmospheres

This property has the problem that it uses the CelestialBody.atmospherePressureSeaLevel of the home planet as definition of 1 atm

Usually this is fine, however if you try changing Kerbin's pressureASL then you end up having wrong ISP / deltaV calculations.

I suggest replacing all instances of PhysicsGlobals.KpaToAtmospheres with either 1 / 101.324996948242 or 0.00986923296440672

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.