Giter Club home page Giter Club logo

nodediggity's People

Contributors

cagarweyne avatar jackpandas avatar jrans avatar lukars avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

nodediggity's Issues

.gitignore

I recommend getting into the habit on always adding .DS_Store to your .gitignore file, even if no one you're working with currently is using a Mac.

Much easier to add it when you first create the repo than have to remove it from everyone's repos later on

Double Readme

You recursed your readme! The readme starts again in the stretch goals section

Use strict style

"use strict" would help clean up some bits in your Javascript, like '==' vs. '==='

DRY

There's a lot of repeated code in your indexfunctions.js that could be refactored

Lazy Issue

Could your codeclimate score be improved?

Repetition

In indexfunctions.js -> maybe -> could make a class so wouldn't have to get item to hide by individual id's.

Folder structure

Your project would be easier to read through and understand with better folder structure. Eg. divided into JS, CSS etc.

CSS as a separate file

Best practice is to have your CSS in a separate file from your html and then import it into the html via a stylesheet link

Importing scripts not yet functional

I think you are trying to load your indexfunctions.js with a script tag, but your server is not set up to handle that yet. You're currently getting down to your else in server.js line 63 and returning 'hello Dan'.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.