joven-heng / pe Goto Github PK

For adding friends, maybe it would be better if you allow friends to be added from different countries? After all, you may have foreign friends or workers that has a work permit who do not own a Singapore phone number or hold a Singapore passport, but yet you may want to save those details.

Perhaps the quickest fix is that this can be just addressed in the UG if one would state that this app is only for the use for Singaporeans only. Or perhaps this can be addressed by simply removing those limitations on phone numbers or passport numbers.

Since sorting will put the capital letters first then small letters since it is sorted by ASCII, one may not be able to find their item(especially in a very large list)

Perhaps just changing it to lowercase before sorting may be a better way( or use a comparator to sort according to lowercase letters)

Not really sure if this is counted as a DG bug but good to know i guess.

Do change this to your own Wanderlust architecture.

For this activity diagram, it is missing the error message that if it is inside the travel plan, an error message will be output by the UI.

It is rather inconsistent with the other diagrams that stated that an error message is output by the UI each time an error occurs (which also describes the type of error).

UC20 and UC21 does not have a page break between their extensions 2b and 2b1.

In the copy command, the copycommand is destroyed at the end. However, for the following commands listed above, they were not destroyed in the sequence diagram.

Copy

add

Steps to recreate:
1)add -travelplan n/Trip to Hawaii sd/2020-11-01 ed/2020-12-32

No error message is given. Perhaps just add in an error message to tell the user that the date is invalid, please use a valid date.

When a user(me) decides to add an activity inside with an invalid date (I.E: 2021-02-31 10:10) 31st does not exist inside the month of Feburary. This results in

being created.

Firstly, this is the wrong date(an incorrect date error should be thrown).

However, what is even more intriguing is if u now add a date (I.E: 2021-02-28 10:10), we should not be able to do so, since they are of the same date and same time,

But it is recognised by Wanderlust, resulting in 2 activities occuring at the same time. (this should not be allowed inside wanderlust as specified in UG)

Steps to recreate

1. go to wishlist
   2)add -activity n/Universal Studios Singapore i/5 l/Sentosa c/88 d/2021-02-31 10:10
   3)add -activity n/Universal Studios Singapore i/5 l/Sentosa c/88 d/2021-02-28 10:10

This error also occurs when we add to any travelplan (Be it activity or accommodation).

In the UG, there were several fields that were filled with "should not be blank"

This led me to assume that the other fields can be blank, however, after testing and reading the UG throughly under the parameters section:

I noticed that the fields are allowed to be not blank. Therefore, I feel that it is a little inconsistent or misleading to place should not be blank in some fields in the parameter list when all the fields are not allowed to be blank. Perhaps just deleting those should not be blank fields should solve the problem, and bolding that the fields should not be blank.

Note that this section also applies to the other fields such as accomodation and friend parameters.

I realised that in your DG, the diagrams (activity) shows a greater range of errors compared to your use cases.

I.E: if an accommodation exists with same name/ friend with same name, then it would throw an error.

However, it is not really reflected here.

In the UG, it is stated under the Activity and Accommodation section that :

However, when I tried to do so, it states that the user can only add an activity that is permitted within the start date and end date. I do understand that it is supposed to be limited by the date and time of the trip due to the sentence above it, but the sentence below was just misleading and led me to assume that one is able to simply add any date and time.

Steps to recreate:

1. create a new travel plan that has a wide range of dates.
2. Just input add -activity n/Fly22 3 l/China i/5 c/20 d/1111-11-11 00:00
   Where the date is copied off the UG

Perhaps it would be better to remove this line alone inside the UG, or even better would be to remove the restriction on having the date of the activity or accommodation to fall within the date of the travel plan. (May be abit more convienient for the user)
OR perhaps just edit it to make it clearer : I.E The user can enter any valid date, as long as it is within the start date or end date of the travel plan.

Maybe allow for some fields to be optional?

One glaring one would be the friend field to allow for friends to be added even if they do not have a passport or mobile number?

However, another possible optional field that could be used would be one that is used in the activity field. This is because not every event needs to have a date and time field (I.E: If one plans to place the activity in the travelplan first, then later change the date depending on the mood/weather during the trip), it could be done since there is an edit command that could be used.

For UC02, perhaps change it to a precondition? It is not really an extension. This also applies for UC05, 06, 09, 10,11,13.