joshuamiller / cljs-tvos Goto Github PK

Josh, nice work and 1 nit:

For parsing you create a DOMParser instance every time you compile a document. Whereas it would be more performant and less memory to create a parser singleton (atom? JS variable?).

Again, this is a NIT so feel free to ignore.

Scenario: I put up a "In progress" loadingTemplate. In the Apple examples there is a state flag on the Presenter.js that recognizes when that is showing so it can dismiss it before pushing the new document on the stack.

Contrary to my DOMParser comment, this seems like it would be better served by finding out if the document exists in the current navigationDocument's stack and, if so, act accordingly.

PS: I am not an experienced JavaScript person so if there is a standard way of doing this directly it may be a moot enhancement request.