josh-berry / tab-stash Goto Github PK

If you delete a tab stash the tabs are gone forever with no option to undo the action.
So i think it would be sensible to have a confirmation prompt before deleting a tab stash in order to avoid any unintentional loss of data.

Describe the bug
Dragging a tab into "Unstashed Tabs" unstashes the tab but doesn't update the view. It leaves the tab listed in the folder where it was originally, even though the bookmark has been removed and the tab has been restored to the correct location in the window.

Interestingly, if you hover over the restored tab in the stash folder, the yellow "unstash and delete" icon has been replaced with a blue "stash this tab" icon. So the view for the tab itself knows it has been unstashed, but it's just appearing in the wrong (original) folder view.

Fortunately, you can work around this by simply closing and reopening the stash list, or by trying to drag the tab again—it always seems to take on the second drag-n-drop attempt.

To Reproduce
Detailed steps to reproduce the behavior:

1. Drag a tab from "Unstashed Tabs" to a stash folder
2. Drag it from the folder back to "Unstashed Tabs"
3. Repeat steps 1 and 2 at least once
4. Notice the symptoms as described above

Expected behavior
The tab gets left where I dragged it.

Desktop (please complete the following information):

• OS: macOS 10.14.3
• Firefox Browser Version: 64, 65 and 66 beta all have this problem

Hi, Josh

As you've mentioned, there's an option to stash a tab to a certain group in a Tab Stash list using blue buttons. It'd be nice to have such an option in a context menu as well.

Thanks!

Regards,
Andrei

'Show Stashed Tabs in a New Tab' button not doing anything for me

The button to open stashed tabs in a new tab does nothing when I click it

• OS: Windows
• Firefox version: 72.0.1
• Tab Stash version: 2.5

I am new to this, I'm sorry for any formatting mistakes

It would be nice if the sidebar and tab view supported the dark theme,
either automatically or through a toggle.

Describe the bug
When i double click on a tab that is unstashed, it does not change the browser focus to that tab.

To Reproduce
Detailed steps to reproduce the behavior:

1. open two tabs
2. Click on the one that is not open
3. See error

Expected behavior
When i double click on an unstashed tab, i expect the tab to be focussed.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Additional context
being able to see the tab before you stash it saves hassle. the same feature would also be usefull for people who just want to cherry pick from a saved stash, not pop the item from the stash.

I see that I can rename a "stash" of bookmarks. Now I wonder if I could also enter keyworks, and also be able to search my stashes et al by keywords?
Thanks!
SE

Describe the Bug

A clear and concise description of what the problem is.

As the summary says. Sometimes this happens, sometimes it doesn't; I think it happens only if the inner folder is older than the outer folder, e.g. the steps below.

Steps to Reproduce

Detailed steps to reproduce the problem:

1. Start with a clean browser (no Tab Stash folder at all, or rename the old tab stash folder to something else)
2. Create a folder named "Tab Stash"
3. Create another folder named "Tab Stash"
4. Put some stashes inside the newer folder
5. Drag the older (empty) folder inside the newer folder
6. Open the UI. Notice that the older empty folder is chosen as the stash root, rather than the newer (parent) folder.

Expected Behavior

A clear and concise description of what you expected to happen.

The parent folder should always be used.

Problem Statement

What problem are you having that is prompting this feature request? Why is this feature important to you? ex. I'm always frustrated when [...]

When using Google Docs, Google Sheets, etc., Tab Stash will use the same icon for all of them, because they are all hosted at docs.google.com. This makes it hard to differentiate which is which when looking at a list of stashed documents.

Preferred Solution

Describe your ideal solution. What is different from today? What would the solution look like? How would it behave?

1. Index favicons by URL instead of by domain
2. For migration purposes, lookup favicons by URL first and by domain second

Alternative Solutions

Are there any other alternatives that would also solve your problem? What would those alternatives look like?

Consider de-duplicating favicons by hashing them and doing a two-level index (URL->hash, hash->icon).

Or, find some reliable way to identify the relevant parts of URLs and index based only on those (so we are storing fewer cache entries).

Additional Context

Add any other context or screenshots about the feature request here.

Problem Statement

When working on a a session and wanting to update a stash, I need to either manually update the stash (adding and removing only the changed tabs one by one), or I need to delete the stash and create a new one under the same name.

Preferred Solution

When saving (or with a different updating button) a stash, the previously saved stash would update the saved tabs to reflect only the ones that are presently open.

This would remove any closed tabs and any duplicate ones.

Alternative Solutions

Not really.

Additional Context

Because the unstashed tabs are current tabs in browser. So when I open the Tab Stash on the sidebar, it displays as a long list, I must collape it by click on the right arrow.
Can you allow me move it to the bottom in the next update?

Describe the bug
When accidentally stashing all tabs, Tab Stash creates multiple groups, each containing multiple/all tabs, then hangs, then deletes all these groups. And the tabs are also gone: not stashed, not bookmarked. :-(

To Reproduce
Detailed steps to reproduce the behavior:

1. Have 50+ tabs open.
2. Right click a tab.
3. Click "Stash tabs" thinking you're stashing that one tab only.
4. Do it two more times.
5. Watch Tab Stash hang with 3 new groups, each filled with all your (non-pinned) open tabs.
6. Wait.
7. Watch Tab Stash come back with no new groups at all, and all your tabs gone at the same time.
8. Look for the tabs in Bookmarks.
9. Don't find the closed tabs nowhere.
10. Use ctrl+shift+T to reopen closed tabs.
11. Find out your number of remembered closed tabs is much smaller (20) than the number of tabs you had open.
12. Cry.
13. Stop crying and file this bug, hoping for the developer to point you to a dump file somewhere that could have your lost tabs' URLs.

Expected behavior
Stash properly all tabs. Or not, but then don't close them.

Desktop (please complete the following information):

• OS: Windows 81 64 bit
• Firefox Browser Version: 68.0.1 64 bits.

Hi there,

I used to be able to re-order / re-arrange the Tab Stash groups, but now I can't seem to do it anymore on Firefox v70.

Is your feature request related to a problem? Please describe.
I would like to get more customization for the different buttons.

Describe the solution you'd like
Give options to:

• disable the button in the context menu and/or the url bar (this would be a nice solution about what I wrote in #16, at least for me )
• choose what the individual buttons should do on left/right-click (basically the options from the dialog menu and allowing to show the menu itself on click)

Describe alternatives you've considered
I don't know if stuff like that is achievable by CSS, but I think it would be nicer to have it easily available for anyone :)

Tab Stash v2.2
Firefox Quantum v65.0 64-bit

In the Extension options page there is "Tab and Memory Management (This Browser). I've tried the radio button for all three options. The only one that actually seems to work properly as its configured is the default: "Hide the tab and keep it loaded in the background".

The other two don't work as expected. For example, selecting "Close the tab immediately" and then stashing tabs will hide the tab and keep it loaded in the background, etc.

If I use "Show Stashed Tabs in a Tab" and click the yellow open&delete button in either a group or an individual item, the Tab Stash tab closes after the tab has (tabs have) been opened and deleted.

Expected behavior
Tab Stash tab should definitely stay open, and preferably as the active tab.

Desktop:

• OS: Linux, Ubuntu 18.04
• Firefox Browser Version: 70.0.1 (64-bit)

Hi, thanks for this great extension!

Is your feature request related to a problem? Please describe.

I stash tabs by topics. When going through past stashes I would like to see
the topic right in the name, otherwise I have to look inside each stash to see what topic it was about.

Describe the solution you'd like
Give stashes a custom name instead just the default date format.

Describe alternatives you've considered

Additional context

Sometimes I need to move tabs from one group to another. Right now, I'm having to drag and drop them one at a time. It would be helpful to be able to select multiple saved tabs then drag and drop them to another group.

specifically the feature that will copy all stashed tabs to one web page. I have tried removing and re-enabling tab stash, no effect? Can you help with this? Win 7 64 bit using the latest firefox
Thanks, Steve

Steps to Reproduce

Detailed steps to reproduce the problem:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected Behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS:
• Firefox Browser Version: [e.g. 60.0.2]

Additional Context

Add any other context about the problem here.

Describe the bug
The icon in address bar is impossible to view.

To Reproduce
1.Install a dark theme like this:
https://addons.mozilla.org/en-US/firefox/addon/solarize-fox/
2. Problems also for see the Tab Stash options in new dark internal pages of Firefox 68 if allow in config:
browser.in-content.dark-mode.

Expected behavior
The icon must be light on dark background.

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Firefox Browser Version: 68 beta8

Describe the bug
If I close all tabs a stashed tab opens, instead of the browser closing.

To Reproduce
Detailed steps to reproduce the behavior:

1. Stash everything
2. Open a few tabs
3. Close all tabs
4. See error

Expected behavior
The browser should close

Desktop (please complete the following information):

• OS: Ubuntu 18.04
• Firefox Browser Version: 71.0 (64-bit)

Additional info
It is possible to delete a stashed tab by closing the one opened by the bug above, but I cannot get a reliable replication method.

Problem Statement

I want to start using brave browser as my default browser

Preferred Solution

Can I please have this same extension for the chrome engine as brave has the same browser engine

I have used OneTab for some time and have a total of 1,219 tabs (URLs) saved. OneTab does have the ability to export to a text file containing just the URLs and page titles with each group delimited by a paragraph break.

It would be very cool if I could import these tabs (URLs) into Tab Stash. I don't think OneTab exports group names, but I'd still be okay with importing the tabs even if they lost their custom group names but remained in their proper groupings.

OneTab has over 81,000 users, and I've already heard a few people say they were switching from OneTab to Tab Stash since Tab Stash is a much better add-on. Being able to import from OneTab could help thousands of people switch to Tab Stash.

Ask your question
Please be as clear and specific as possible. The more information you provide up-front, the easier it will be for us to respond to your question quickly and accurately.

Supporting Details (please complete the following information if relevant):

• OS: [e.g. Mac, Windows, Linux]
• Firefox Browser Version: [e.g. 60.0.2]

There's a feature OneTab has that would be excellent in Tab Stash. I used it a lot in OneTab, and now that I've switched to Tab Stash, I miss it.

It would be cool to have the ability to send a tab (or selected tabs) to a specific group. For example, if a few days ago I created a group named "foo" and I now have a tab I would like to add to that group, it would be cool to have a contextual menu option like "Send This Tab to Group >>". When you click on that menu item, it opens a hierarchal menu to the side listing all of your groups. I could select "foo", and it would send that tab to my group named "foo".

Getting icons from Mozilla API would be ideal - or until that becomes possible, getting from the site itself (like Bookmark-search-plus-2 does). Simply having the option to turn the feature off would be good enhancement, though.

Describe the bug
If I open a stash with a few hundred tabs and switch browser windows while the tabs are being opened, some of the tabs get opened in the newly focused window. They should open in the original window when the open all tabs button was clicked.

To Reproduce
Detailed steps to reproduce the behavior:

1. Have two, (preferably empty to see the problem easily) browser windows available.
2. Have a stash with a couple of hundred or so tabs.
3. Click 'Open all tabs in this group' button in the sidebar
4. Quickly switch to the other window while tabs are still being opened.
5. Notice that some tabs got opened in the new window we just switched to.

Expected behavior
All tabs should open in the original window the "Open all tabs" button was clicked in.

Screenshots
.

Desktop (please complete the following information):

• OS: Mac
• Firefox Browser Version: 68.0

Additional context
.

I would love to have the option to stash all tabs to the left and right. Many times I have important tabs (that I don't want to pin) in the left, and extraneous tabs have started piling up in the right. Choosing "Stash Tabs to the Right" from the last one I'd like to keep would be great! Occasionally I've also needed to stash the left ones, and some other people might find it more useful.

If you need help implementing this, please let me know.

Problem Statement

Tab stash puts open tabs to "sleep", and we can manually "wake them up" at any time. But what about simply snoozing tabs? There are add-ons for that, but I already trusted Tab Stash with (probably all) the required permissions and it already manages my "sleeping" tabs, so why not make it capable of waking them up too, thus implementing a snooze feature?

Preferred Solution

Besides "stash", there should be a "snooze" option.

Alternative Solutions

There are specific add-on, but the more add-ons are installed, the more sluggish Firefox gets, and the more add-ons requiring sensitive permissions are installed , the more vulnerable are one's data.

Additional Context

I love Tab Stash. Could it be even better in this way?

I am starting to have a lot of stashes such that I can't see them all, in one glance. Therefore, I would like to be able to save related stashes into a "group" of stashes.
Thank you for the great add-in.
Steve

Describe the bug
See attached gif. Stash works but unstash is completely broken suddenly. Don't see any exceptions in the console log. I had installed Temporary Containers recently and it was working after that but suddenly, even after disabling that, restarting the browser etc. it is not working.

To Reproduce
Detailed steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
https://gyazo.com/b7dbd2aeee76533f4efa0c725966cb41

Desktop (please complete the following information):

• OS: macOS
• Firefox Browser Version: 67.0.4

Additional context
The only remaining way for me to open it is via the firefox right click menu > "Open Link in New Tab" etc.

I upgraded to firefox 67.0.1 quantuum 64 bit windows 7 a few days ago, after a system restore. the stash inferface will no longer come up, but stash is still stashing my open tabs. but I miss the stash interface. But my stashes are still there.
Thanks,
Steve

The program simply doesn´t work with my Firefox. It open an empty panel and keeps stashing for a very long time, and never really ends this process. This screenshot is after two hours of the program working.

I use Windows 10 64 bits, and Firefox Quantum 66.0.3. I don´t know if there´s some relation between the two issues, but I can´t work well with the Favorites on Firefox, the menu doesn´t obey to commands and it never saves alterations, even though I have done everything that is said in their support to solve the problem.

Describe the bug
Opening tabs too quickly causes some to be closed

To Reproduce
Detailed steps to reproduce the behavior:

1. Try to open 2 or more tabs from stash by clicking on tab entries from the sidebar really fast (while some in early loading stages)
2. Any tabs in an early loading stage will be closed by one of the later clicks

Expected behavior
All tabs that where clicked on should be opened

Desktop (please complete the following information):

• OS: Windows 10
• Firefox Browser Version: 67.0.3

Additional context
I took a brief look at the tab opening code and my guess it's due to this:

I think you also want to take into consideration the curtab.status, so it doesn't close a loading tab.

Will it be possible to add some kind of auto-saving/loading?
When you are in a stash, it would automatically save the changes (in the open tabs) to that stash.

The idea is mainly to allow to synchronize open tabs between Firefox on different computers.

Describe the Bug

Losing all the stashed tabs with no apparent way of restoring them back.

Steps to Reproduce

Detailed steps to reproduce the problem:

1. Open your browser and some tabs in it
2. Open another instance of your browser and leave it in blank.
   3.Close the first instance with tabs.
3. Navigate with the second instance, create a stash and close the browser

Expected Behavior

You should have lost all your previous stashes and whenever you open the Tab Stash window you would be welcome by a blank page.

Screenshots

Solved it before taking this 0_0 (Sorry)

Desktop (please complete the following information):

• OS: Windows 10
• Firefox Browser Version: [73.0.1 (64-bit)]

Additional Context

The program seems to create a new parent folder.
Maybe the firefox version used when the bug happened was a previous one.

Describe the Bug

A clear and concise description of what the problem is.
When the links in the rearranged in the Tab view, the link will be opened in the browser. I think this is unwanted and such behavior does not show if the link is dragged and dropped in the sidebar view.

Steps to Reproduce

Detailed steps to reproduce the problem:

1. Open Tab Stash with the Tab view.
2. Drag and drop a link to move it to another group.
3. The link will be rearranged but it is also opened in the browser.

Expected Behavior

A clear and concise description of what you expected to happen.
If the saved link is rearranged in the sidebar view, the function works great. And the expected behavior is that the link is moved without opened in Firefox if the Tab view if used.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Ububutu 18.04
• Firefox Browser Version: 75.0

Additional Context

Add any other context about the problem here.

Describe the bug
Tabs which are in the built-in reading mode of Firefox can't be stashed. They also don't show up in the "unstashed tabs" group, but do once reader mode is disabled

To Reproduce

1. load random page
2. activate reader view (F9)
3. try to stash the tab

Expected behavior
Not sure how the reader view works on a technical side and if anything can be done about this, but it would b e nice if that tab can be stashed as well.

Desktop (please complete the following information):

• OS: Windows 10
• Firefox Browser Version: 68.0b10 (64-bit) -> Firefox Beta

Additional context
Alternative suggestions for solutions (if possible):

• stash the tab outside of reader view
• notify if tabs didn't get stashed/are in reader view when stashing the current session

This bug could get especially frustrating if one hasn't enabled session restore, stashes his current session and mindlessly closes Firefox without noticing that some tabs stayed opened (because they are in reader view and therefore not recognized). As a result the tabs would be lost.

In the Firefox addons dark page, the tab-stash icon is hard to see, will be great make a medium gray or something like that.
For apply the dark theme set browser.in-content.dark-mode to true (default in Firefox 70 beta).

Describe the bug
I stashed a session yesterday which had tabs with file:///-URIs. Stashing them worked, but restoring the group only brings back the tabs with https scheme, the file tabs remain in the group. Also clicking on one of these stashed tabs or trying to use the restore-and-delete-button for one particular tab does not work.

To Reproduce

1. Open website of choice in a tab
2. Open file:///home/user/what/ever.pdf in another tab
3. Stash the tabs
4. Restart the browser and click on the yellow restore and delete button for the group

Expected behavior
Both tabs are restored and the group gets deleted.

Desktop (please complete the following information):

• OS: Kubuntu 19.04
• Firefox Browser Version: 67.0.4

Is your feature request related to a problem? Please describe.
When i have alot of stashes and using ths sidebar, it is difficult to get an overview of them, especially on a laptop because:

• the font size of the stash name is large - can only show 10 closed stashes
• the side-bar always opens with the stashes open
• option to 'sort' the stash order by alpha, number of tabs etc.

Describe the solution you'd like
options outlined above.

Describe alternatives you've considered
using the stash tab. It has similar options, but removes you from the context of the open tab you are working with.

Additional context

Tab Stash used to automatically de-duplicate bookmarks when saving to a stash, but there were problems with over-aggressive de-duplication (see #31) which would in some cases delete things that weren't duplicates, so this feature was disabled. It would be nice to find a way to bring it back, either automatically or add some way of allowing the user to trigger de-duplication manually.

Is your feature request related to a problem? Please describe.
I would like to stash selected tabs with a shortcut. Right now, we can either stash all tabs, or only the active tab, there is no way to stash several selected tabs with a shortcut.

Describe the solution you'd like
I think a shortcut for this would be very useful. It would be more convenient and time saving to have this option than having to right click and select from the menu.

Does tab-stash do anything that may not scale well with large numbers of windows and tabs open? Possibly something that might trigger a sync every time a tab is opened or closed?

I have more than 50 windows with a total of more than 1200 tabs (clearly tab-stash performance isn't my only problem), but I was hoping to use it to be able to reduce the number of things open and be able to clear them out from any of several systems. Unfortunately, once I activated it performance ground to a halt any time tab operations happened (e.g. moving to a different tab that needed to reload taking minutes). Disabling tab-stash has returned to decent performance.

Monitoring with Resource Monitor while this was happening showed no obvious issues with CPU, memory or disk/disk queue.

My initial thought was that if syncs weren't as granular as they could be then this might be triggering a full sync every time a tab was opened or closed, possibly then causing a partial hang during the sync.

This is on Windows, x64, FF 68.0.1

Is your feature request related to a problem? Please describe.
when researching a topic, i would like to be able to create a stash for that topic, and then save the stash for later research or sharing with a firefox/browser that is not in sync with this one.

Describe the solution you'd like
A menu option to save, load, append, replace items from a stash as bookmarks.

Describe alternatives you've considered
N/A

Additional context
N/A

Describe the bug
If I have Tab Stash as the selected sidebar and I open a new window with Cmd+N on macOS, Firefox freezes for quite a long time (around a minute or so) before becoming usable.

To Reproduce
Detailed steps to reproduce the behavior:

1. Make sure Tab Stash is open in the sidebar.
2. File Menu > Open New Window
3. Try to type something in the new window address bar. Notice how your input lags for multiple seconds and sometimes almost a minute.
4. Repeat the same with a different sidebar like Bookmarks open and notice how there is instant responsiveness.

Expected behavior
There should be no freezing of the Firefox UI.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: macOS Catalina 10.15.2
• Firefox Browser Version: 71.0

Additional context
Add any other context about the problem here.

my pinned tabs will load in reverse order.

Steps to Reproduce

create some pinned tabs, shut down and restart notice order change

Expected Behavior

pinned tabs stay in order

Desktop (please complete the following information):

Win 10
Firefox Nightly

I just snagged this addon yesterday, and it happened on the first restart. I thought it may be a first time config thing, so I re-arranged them. just opened FF and they are reversed again.

Hi Josh,

Sorry I was unclear asking that on a Firefox addons page.

As of now, we have two options when clicking the stash button - to close (or hide as set in prefs) the tab or to keep tab open (using ALT) after stashing. The "close or hide" behavior is set in the preferences. There's no way to temporarily override that setting, using let's say CMD key with the click. That'd be nice actually.

i.e

click - close (or hide, as set in prefs) the tab
alt-click - leave the tab opened
ctrl-click - hide (or close, as set in prefs) the tab

Regards,
Andrei

There is a known issue related to Firefox Sync and Tab Stash where, on rare occasions, saved tabs and groups might suddenly disappear from your stash. When this happens, it usually involves groups/tabs that were saved, moved or renamed recently.

If this happens to you, follow these steps to locate and restore your missing bookmarks/tabs:

1. Open the Firefox menu (the three horizontal lines in your toolbar)
2. Choose "Library", then "Bookmarks"
3. Choose "Show All Bookmarks" at the very bottom
4. Find and open the "Other Bookmarks" folder in the sidebar. If any stashed folders appear there, drag them back into the "Tab Stash" folder.
5. If any bookmarks associated with stashed tabs appear in the "Other Bookmarks" folder, create a new folder for them, drag the bookmarks into the new folder, and drag the new folder into the "Tab Stash" folder.
6. Find and open the "Tab Stash" folder. If any bookmarks appear there, drag them into the appropriate folder underneath "Tab Stash". (You can create a new folder for these "orphaned" bookmarks if you prefer.)

As of right now, I believe this is a Firefox issue, not a bug in Tab Stash (but please do not comment on the Firefox bug—linked below—unless you have some technical details to add). However, I'm opening this issue to track possible mitigations/workarounds that could be applied in Tab Stash itself.

ref: https://bugzilla.mozilla.org/show_bug.cgi?id=1549648

I noticed that you mention Emacs in the docs. I'm a long time Emacs user but haven't used it for Javascript programming so far. I want to teach myself some Javascript by going through the code of some great exensions (like tab-stash). Now I wonder if you could share your Emacs setup for this project?

I'm currently experimenting with tide on Emacs 26.3. Just curious if you can share some tips for JS development with Emacs.