jortiz31 / down2golf Goto Github PK

View Code? Open in Web Editor NEW

1.0 3.0 1.0 15.15 MB

Ruby 53.45% CSS 16.33% HTML 29.88% JavaScript 0.27% CoffeeScript 0.07%

down2golf's Introduction

ARE YOU DOWN TO GOLF?

TECHNOLOGIES USED
RUBY ON RAILS
POSTRGRES
FOUNDATION
JAVASCRIPT
JQUERY
HTML
SASS
GIT
GEMS/API
RATY RATE
GOOGLE MAP API
OPEN WEATHER APP
DEVISE
BRAINTREE
RAILS ERD
GON
FIGARO
CLOUDINARY
GRAVATAR
MAILBOXER
WILL_PAGINATE

MILESTONES

Don't forget to rake your routes 😉

Eric's Gem of Code 😎

Jonathan Gets Hacky with Google Maps

What this app does:

This app solves the ‘lonely golfer issue’ by giving our users a chance to browse golf courses and matches created by other users in the bay area.

When you log into our app, you will be given the option to login or sign up.(NOT CONSIDERING PRO ACCT) Once a user does that, he/she will be directed to our matches index pages that displays a list of matches being held by other users(moderators). The user has a chance to join by their preference of golf course or users in the match.

After creating or joining a match, a user is allowed to view the match on the map show page a see a bevy of information, including a picture of the golf course, time/date, name of match(ex. Jonathan’s Nine Hole for Sunday), users involved and also a map to the golf course where the match is being held, and comments being posted by users that may want to join and users that have already joined.

A user will experience the look and feel of a single page app (SPA) by having every form conveniently in a modal. With an exception of the comment form on the match show page.

A user may edit or view their profile on the profile show page, but may not search or view other users profiles. If a user did not choose to log in or sign up, they are allowed to surf the golf courses that we are affiliated with but may not view the matches index page. However they may view the golf courses index/show page and see what matches are being held or upcoming on that particular course, including the users joined in that match.

Down2Golf free allows you as a user to join one match at a time. For our stretch we will only allow pro users to create matches. Fee users may only join those matches, however they are limited to one a time.

USER STORY

A user should be able to sign up as free or premium.
A user should be able to create matches.
A user should be able to join matches.
A user should be able to view matches that he’s joined.
A user should be able to view all golf courses.
A user should be able to message other users.
A user should be able to leave ratings for golf courses.
A user should be able to comment on a match or course.

SPECIAL THANKS TO

EVERYONE, GOODLUCK!

down2golf's People

Contributors

Stargazers

Watchers

Forkers

scoobaroo

down2golf's Issues

When I'm on a course and click "new match at this course" why do I have to choose the course again?

Hacked! Add authorization to routes that other users shouldn't be able to access.

https://down2golf.herokuapp.com/matches/6

You shouldn't allow the wrong user on https://down2golf.herokuapp.com/matches/6/edit

nor should they be permitted to PUT or DELETE https://down2golf.herokuapp.com/matches/6

commit messages matter

ac303a7 <-- 'fixed'
6f3160d <-- 'most front end done'
4fa3185 <-- 'try again'
46b0298 <-- 'pulling from sprint 2'

JS that you didn't write belongs in vendor

https://github.com/jortiz31/down2golf/blob/master/app/assets/javascripts/ImageSelect.jquery.js

Don't commit broken / incomplete code to master

e0b3c1e

+  .controller('CoursesController', CoursesController);
 +
 +ListsController.$inject = ['CoursesService', '$location'];
 +function ListsController(   CoursesService,   $location  ) {

This is half-way a ListsController and half-way a CoursesController. Your future co-workers will not appreciate you checking in something like this.

bower_components should be moved into vendor

you can configure it to use a different directory

create match without being signed-in is an error

I was able to create a match without signing in but after clicking submit it took me to https://down2golf.herokuapp.com/matches
This was just an error page on heroku.

No authentication on critical methods of MatchesController

I just deleted 'Jonathan's match': https://down2golf.herokuapp.com/matches/5

  def destroy
    @match.destroy
    flash[:notice]="Match Successfully Deleted!"
    redirect_to matches_path
  end

Try to include a check to make sure that the match's creator is the current_user.

Why did logging in take me to edit my profile?

Is that what 90% of users do every time they login?

What is the braintree stuff in the .travis.yml file?

- external-ci-notifications+braintree_rails_example@getbraintree.com

CoursesController code not tested

https://github.com/jortiz31/down2golf/blob/master/app/controllers/courses_controller.rb
Is @Course set in the following methods:

  def edit
    render :edit
  end

  def update
    @course.update(course_params)
  end

  def destroy
    @course.destroy
  end

code quality - User Model

This doesn't seem right:

  def update_with_password(params, *options)
    current_password = params.delete(:current_password)
  if params[:password].blank?
    params.delete(:password)
    params.delete(:password_confirmation) if params[:password_confirmation].blank?
  end
  result = if params[:password].blank? || valid_password?(current_password)
    update_attributes(params, *options)
  else
    self.assign_attributes(params, *options)
    self.valid?
    self.errors.add(:current_password, current_password.blank? ? :blank : :invalid)
    false
  end
    clean_up_passwords
    result
  end

Did you code-review?