jordaneremieff / asgi-examples Goto Github PK

I was not sure where to start this discussion; this seems like neutral ground :)

cc @pgjones @tomchristie

ASGI is great! I can pick a web framework and swap out the server with zero effort. Even the way to run an app from the terminal is the same (kind of).

However, the CLI arguments differ (e.g. -b in hypercorn vs --host in uvicorn). Both hypercorn and uvicorn have a run() method that I can put in my if __name__ == '__main__' section. But the signature and way to configure is very different.

Can we please discuss fixing this? (I checked the issue trackers of hypercorn and uvicorn whether this topic was raised before, did not see any, sorry if I missed it.)

To kick this discussion off, here's my proposal:

• Define common CLI args names (at least for the functionality that is shared).
• Have servers define a some_asgi_server.run_asgi() function. The _asgi suffix makes that non-ASGI servers can potentially expose the function too (via an adapter).
• Allow configuration via keyword arguments to the above function, that have the same names as the CLI args.

Since this repo may serve as useful reference point for people looking into ASGI, there is a bit of cleanup required. There have been quite a few advances in the ASGI ecosystem and in my personal understanding of both the spec and asyncio that should be reflected.

I'm impressed with your repo, it's great for getting more insight on ASGI.

I saw the Flask ASGI Adapter (which completely blew my mind, just considering Flask could run websockets like that) and I'm wondering what the catch is? What parts of Flask won't work?